Update dg #247
Merged
Update dg #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiantoh
approved these changes
Nov 8, 2020
There was a problem hiding this comment.
LGTM!
Regarding the UML diagrams, I actually meant this section: https://ay2021s1-cs2103t-t11-1.github.io/tp/DeveloperGuide.html#logic-component . Sorry that I wasn't clear enough. But I think it's fine - we don't have to update it.
Regarding the architecture diagrams, I think we shouldn't include AddressBookParser since the architecture diagram right now mainly focuses on the different packages and AddressBookParser is sort of within Logic
Also, thanks for updating the DG and making it more consistent!
|
Okay give me a moment to update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated architecture diagrams (not sure if it's correct though).
Update DG.