Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Appointment storage #68

Merged
merged 13 commits into from
Oct 7, 2020
Merged

Add Appointment storage #68

merged 13 commits into from
Oct 7, 2020

Conversation

sebastiantoh
Copy link

@sebastiantoh sebastiantoh commented Oct 6, 2020

Based off PR #62 (review that PR first before reviewing this)

Closes #61

  • Added JsonAdaptedAppointment
  • Integrated them into JsonSerializableAddressBook
  • Added corresponding tests

@sebastiantoh sebastiantoh added this to the v1.2 milestone Oct 6, 2020
Copy link

@hakujitsu hakujitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor JavaDoc comment, LGTM!

src/main/java/seedu/address/model/Model.java Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@4719f44). Click here to learn what that means.
The diff coverage is 75.18%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #68   +/-   ##
=========================================
  Coverage          ?   74.82%           
  Complexity        ?      486           
=========================================
  Files             ?       79           
  Lines             ?     1454           
  Branches          ?      155           
=========================================
  Hits              ?     1088           
  Misses            ?      323           
  Partials          ?       43           
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (?)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (?)
...rc/main/java/seedu/address/model/ModelManager.java 89.83% <0.00%> (ø) 26.00 <0.00> (?)
...a/seedu/address/model/appointment/Appointment.java 48.38% <48.38%> (ø) 8.00 <8.00> (?)
src/main/java/seedu/address/model/AddressBook.java 84.61% <70.58%> (ø) 17.00 <7.00> (?)
...dress/model/appointment/UniqueAppointmentList.java 81.81% <81.81%> (ø) 13.00 <13.00> (?)
...tment/exceptions/AppointmentNotFoundException.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...ment/exceptions/DuplicateAppointmentException.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
.../seedu/address/storage/JsonAdaptedAppointment.java 100.00% <100.00%> (ø) 7.00 <7.00> (?)
...u/address/storage/JsonSerializableAddressBook.java 100.00% <100.00%> (ø) 6.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4719f44...78f6f11. Read the comment docs.

# Conflicts:
#	src/main/java/seedu/address/commons/core/Messages.java
#	src/main/java/seedu/address/storage/JsonSerializableAddressBook.java
#	src/test/data/JsonSerializableAddressBookTest/duplicatePersonAddressBook.json
#	src/test/data/JsonSerializableAddressBookTest/invalidPersonAddressBook.json
#	src/test/data/JsonSerializableAddressBookTest/typicalPersonsAddressBook.json
Copy link

@AaronnSeah AaronnSeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full stop added by sebastian

@AaronnSeah AaronnSeah requested review from hakujitsu and removed request for hakujitsu October 7, 2020 11:07
# Conflicts:
#	src/main/java/seedu/address/model/Model.java
#	src/main/java/seedu/address/storage/JsonSerializableAddressBook.java
#	src/test/data/JsonAddressBookStorageTest/invalidAndValidPersonAddressBook.json
#	src/test/data/JsonAddressBookStorageTest/invalidPersonAddressBook.json
#	src/test/data/JsonSerializableAddressBookTest/duplicatePersonAddressBook.json
#	src/test/data/JsonSerializableAddressBookTest/duplicateTagAddressBook.json
#	src/test/data/JsonSerializableAddressBookTest/invalidPersonAddressBook.json
#	src/test/data/JsonSerializableAddressBookTest/invalidTagAddressBook.json
#	src/test/data/JsonSerializableAddressBookTest/typicalPersonsAddressBook.json
#	src/test/java/seedu/address/storage/JsonAddressBookStorageTest.java
#	src/test/java/seedu/address/storage/JsonSerializableAddressBookTest.java
@sebastiantoh sebastiantoh merged commit 774bc4f into AY2021S1-CS2103T-T11-1:master Oct 7, 2020
@sebastiantoh sebastiantoh deleted the appointment-storage branch October 7, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Appointment model and storage
4 participants