-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Appointment storage #68
Add Appointment storage #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the minor JavaDoc comment, LGTM!
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=========================================
Coverage ? 74.82%
Complexity ? 486
=========================================
Files ? 79
Lines ? 1454
Branches ? 155
=========================================
Hits ? 1088
Misses ? 323
Partials ? 43
Continue to review full report at Codecov.
|
# Conflicts: # src/main/java/seedu/address/commons/core/Messages.java # src/main/java/seedu/address/storage/JsonSerializableAddressBook.java # src/test/data/JsonSerializableAddressBookTest/duplicatePersonAddressBook.json # src/test/data/JsonSerializableAddressBookTest/invalidPersonAddressBook.json # src/test/data/JsonSerializableAddressBookTest/typicalPersonsAddressBook.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
full stop added by sebastian
# Conflicts: # src/main/java/seedu/address/model/Model.java # src/main/java/seedu/address/storage/JsonSerializableAddressBook.java # src/test/data/JsonAddressBookStorageTest/invalidAndValidPersonAddressBook.json # src/test/data/JsonAddressBookStorageTest/invalidPersonAddressBook.json # src/test/data/JsonSerializableAddressBookTest/duplicatePersonAddressBook.json # src/test/data/JsonSerializableAddressBookTest/duplicateTagAddressBook.json # src/test/data/JsonSerializableAddressBookTest/invalidPersonAddressBook.json # src/test/data/JsonSerializableAddressBookTest/invalidTagAddressBook.json # src/test/data/JsonSerializableAddressBookTest/typicalPersonsAddressBook.json # src/test/java/seedu/address/storage/JsonAddressBookStorageTest.java # src/test/java/seedu/address/storage/JsonSerializableAddressBookTest.java
Based off PR #62 (review that PR first before reviewing this)
Closes #61