Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tag find command #92

Merged
merged 3 commits into from
Oct 13, 2020

Conversation

Asthenosphere
Copy link

Closes #15

The following screen is the result of the command tag find 4
Screenshot 2020-10-12 at 11 34 03 PM

@Asthenosphere Asthenosphere added this to the v1.2b milestone Oct 12, 2020
Copy link

@sebastiantoh sebastiantoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just checking, tagging of sales is not yet implemented right?

@codecov-io
Copy link

Codecov Report

Merging #92 into master will increase coverage by 0.71%.
The diff coverage is 70.58%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
+ Coverage     70.62%   71.33%   +0.71%     
- Complexity      760      775      +15     
============================================
  Files           124      126       +2     
  Lines          2417     2449      +32     
  Branches        289      292       +3     
============================================
+ Hits           1707     1747      +40     
+ Misses          613      602      -11     
- Partials         97      100       +3     
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...eedu/address/logic/commands/tag/DeleteCommand.java 76.47% <ø> (-1.31%) 7.00 <0.00> (ø)
.../seedu/address/logic/commands/tag/EditCommand.java 62.22% <ø> (+5.70%) 9.00 <0.00> (ø)
...du/address/logic/parser/tag/TagCommandsParser.java 37.50% <0.00%> (-5.36%) 3.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/main/java/seedu/address/model/AddressBook.java 60.00% <50.00%> (-0.56%) 32.00 <2.00> (+2.00) ⬇️
...rc/main/java/seedu/address/model/ModelManager.java 75.00% <50.00%> (-0.59%) 32.00 <1.00> (+1.00) ⬇️
.../seedu/address/logic/commands/tag/FindCommand.java 73.68% <73.68%> (ø) 8.00 <8.00> (?)
...du/address/logic/parser/tag/FindCommandParser.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...tment/exceptions/AppointmentNotFoundException.java
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 991f79a...51e02ec. Read the comment docs.

Copy link

@sebastiantoh sebastiantoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sebastiantoh sebastiantoh merged commit 4e9978e into AY2021S1-CS2103T-T11-1:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As an efficient salesman, I can search contacts, sales etc. by tags
3 participants