-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tag operations for sales #96
Add tag operations for sales #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: sebastiantoh <sebas.tsj.98@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
============================================
+ Coverage 70.90% 71.31% +0.40%
- Complexity 816 837 +21
============================================
Files 132 132
Lines 2612 2698 +86
Branches 314 335 +21
============================================
+ Hits 1852 1924 +72
- Misses 649 658 +9
- Partials 111 116 +5
Continue to review full report at Codecov.
|
Closes #96
![Screenshot 2020-10-13 at 5 05 01 PM](https://user-images.githubusercontent.com/58675456/95840072-50554680-0d76-11eb-88ba-728ea7850871.png)
Result of tag edit for sales:
Result of tag delete for sales:
![Screenshot 2020-10-13 at 5 05 21 PM](https://user-images.githubusercontent.com/58675456/95840084-53503700-0d76-11eb-9251-442e6f5b53f1.png)
Result of adding a new sale with a new tag:
![Screenshot 2020-10-13 at 5 07 07 PM](https://user-images.githubusercontent.com/58675456/95840305-8f839780-0d76-11eb-863b-8e008f9fe0c1.png)