Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag operations for sales #96

Merged
merged 18 commits into from
Oct 13, 2020

Conversation

Asthenosphere
Copy link

@Asthenosphere Asthenosphere commented Oct 13, 2020

Closes #96
Result of tag edit for sales:
Screenshot 2020-10-13 at 5 05 01 PM

Result of tag delete for sales:
Screenshot 2020-10-13 at 5 05 21 PM

Result of adding a new sale with a new tag:
Screenshot 2020-10-13 at 5 07 07 PM

@Asthenosphere Asthenosphere added this to the v1.2b milestone Oct 13, 2020
@Asthenosphere Asthenosphere marked this pull request as draft October 13, 2020 05:14
@Asthenosphere Asthenosphere marked this pull request as ready for review October 13, 2020 08:59
Copy link

@sebastiantoh sebastiantoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/main/java/seedu/address/model/AddressBook.java Outdated Show resolved Hide resolved
@sebastiantoh
Copy link

sebastiantoh commented Oct 13, 2020

Not really relevant to this PR, but I think the parameter and example for editing a tag is missing the updated tag name. Example should be something like tag edit 1 t/furniture. Feel free to merge this PR if you want to resolve this in another PR.

image

Co-authored-by: sebastiantoh <sebas.tsj.98@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #96 into master will increase coverage by 0.40%.
The diff coverage is 52.29%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #96      +/-   ##
============================================
+ Coverage     70.90%   71.31%   +0.40%     
- Complexity      816      837      +21     
============================================
  Files           132      132              
  Lines          2612     2698      +86     
  Branches        314      335      +21     
============================================
+ Hits           1852     1924      +72     
- Misses          649      658       +9     
- Partials        111      116       +5     
Impacted Files Coverage Δ Complexity Δ
...edu/address/logic/commands/contact/AddCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...du/address/logic/commands/contact/EditCommand.java 95.89% <ø> (ø) 12.00 <0.00> (ø)
.../seedu/address/logic/commands/sale/AddCommand.java 30.43% <0.00%> (ø) 3.00 <0.00> (ø)
...edu/address/logic/commands/sale/DeleteCommand.java 26.31% <0.00%> (ø) 3.00 <0.00> (ø)
.../seedu/address/logic/commands/tag/FindCommand.java 77.77% <0.00%> (+4.09%) 8.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 75.51% <0.00%> (-3.22%) 36.00 <0.00> (ø)
...a/seedu/address/model/person/UniquePersonList.java 68.57% <0.00%> (-22.46%) 29.00 <0.00> (+1.00) ⬇️
src/main/java/seedu/address/model/AddressBook.java 71.79% <58.53%> (+11.11%) 47.00 <6.00> (+15.00)
src/main/java/seedu/address/model/sale/Sale.java 94.44% <87.50%> (+27.77%) 16.00 <2.00> (+2.00)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc4217...94e8f40. Read the comment docs.

@sebastiantoh sebastiantoh merged commit 47c2856 into AY2021S1-CS2103T-T11-1:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants