Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG with details of export implementation #103

Merged
merged 6 commits into from
Oct 20, 2020

Conversation

yanchenglee98
Copy link

Add description of the implementation of export feature in DG
Closes #102

@yanchenglee98 yanchenglee98 added this to the v1.3 milestone Oct 19, 2020
@yanchenglee98 yanchenglee98 self-assigned this Oct 19, 2020
@codecov-io
Copy link

codecov-io commented Oct 19, 2020

Codecov Report

Merging #103 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #103      +/-   ##
============================================
+ Coverage     72.29%   72.32%   +0.02%     
- Complexity      454      463       +9     
============================================
  Files            79       82       +3     
  Lines          1462     1485      +23     
  Branches        151      152       +1     
============================================
+ Hits           1057     1074      +17     
- Misses          359      364       +5     
- Partials         46       47       +1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/model/Model.java 100.00% <0.00%> (ø) 1.00% <0.00%> (ø%)
...rc/main/java/seedu/address/model/ModelManager.java 100.00% <0.00%> (ø) 24.00% <0.00%> (+1.00%)
.../java/seedu/address/model/event/AttendeesList.java 66.66% <0.00%> (ø) 1.00% <0.00%> (?%)
...ava/seedu/address/model/event/UniqueEventList.java 85.71% <0.00%> (ø) 2.00% <0.00%> (?%)
src/main/java/seedu/address/model/event/Event.java 55.55% <0.00%> (ø) 3.00% <0.00%> (?%)
src/main/java/seedu/address/model/AddressBook.java 92.30% <0.00%> (+0.64%) 13.00% <0.00%> (+1.00%)
...rc/main/java/seedu/address/logic/LogicManager.java 76.19% <0.00%> (+1.19%) 4.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4814ec...cbfc916. Read the comment docs.

@yanchenglee98 yanchenglee98 requested review from teekoksiang and schoolex and removed request for schoolex and teekoksiang October 19, 2020 15:13
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
Copy link

@schoolex schoolex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some design format that we still need to discuss

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
Copy link

@schoolex schoolex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, 1 typo to fix

@schoolex schoolex merged commit 01bb070 into AY2021S1-CS2103T-T11-2:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update DG with details of export implementation
3 participants