Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG: add implementation for add-event #110

Merged
merged 4 commits into from
Oct 21, 2020

Conversation

jieffyy
Copy link

@jieffyy jieffyy commented Oct 21, 2020

Update the DG with add-event's details.

@jieffyy jieffyy added this to the v1.3 milestone Oct 21, 2020
@codecov-io
Copy link

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #110   +/-   ##
=========================================
  Coverage     68.38%   68.38%           
  Complexity      496      496           
=========================================
  Files            91       91           
  Lines          1683     1683           
  Branches        182      182           
=========================================
  Hits           1151     1151           
  Misses          469      469           
  Partials         63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 069e417...a9c2379. Read the comment docs.

Copy link

@yanchenglee98 yanchenglee98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some minor nits and things to discuss

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
Copy link

@yanchenglee98 yanchenglee98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanchenglee98 yanchenglee98 merged commit 41b2f6d into AY2021S1-CS2103T-T11-2:master Oct 21, 2020
@jieffyy
Copy link
Author

jieffyy commented Oct 23, 2020

EDIT: was part of #91.

@jieffyy jieffyy self-assigned this Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants