Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list-group command to display all student groups #126

Merged
merged 8 commits into from
Oct 24, 2020

Conversation

teekoksiang
Copy link

  • Add list-group command to display all student groups
  • Add test cases for testing ListGroupCommand

@teekoksiang teekoksiang added this to the v1.3 milestone Oct 23, 2020
@teekoksiang teekoksiang self-assigned this Oct 23, 2020
@teekoksiang teekoksiang linked an issue Oct 23, 2020 that may be closed by this pull request
@jieffyy jieffyy assigned jieffyy and teekoksiang and unassigned teekoksiang and jieffyy Oct 23, 2020
Copy link

@jieffyy jieffyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, almost LGTM 👍 Have some clarifications to make regarding the intended usage though.

@codecov-io
Copy link

Codecov Report

Merging #126 into master will increase coverage by 0.27%.
The diff coverage is 91.30%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #126      +/-   ##
============================================
+ Coverage     68.72%   69.00%   +0.27%     
- Complexity      535      542       +7     
============================================
  Files            93       94       +1     
  Lines          1848     1871      +23     
  Branches        207      209       +2     
============================================
+ Hits           1270     1291      +21     
  Misses          490      490              
- Partials         88       90       +2     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...seedu/address/logic/commands/ListGroupCommand.java 90.47% <90.47%> (ø) 5.00 <5.00> (?)
.../seedu/address/logic/parser/AddressBookParser.java 80.95% <100.00%> (+0.95%) 13.00 <0.00> (+1.00)
...rc/main/java/seedu/address/model/ModelManager.java 86.66% <100.00%> (+0.22%) 26.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb3d15...eddc1c4. Read the comment docs.

Copy link

@jieffyy jieffyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍

@jieffyy jieffyy merged commit 700733d into AY2021S1-CS2103T-T11-2:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List all the student groups
3 participants