Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering by event #147

Merged
merged 10 commits into from
Oct 28, 2020
Merged

Conversation

yanchenglee98
Copy link

@yanchenglee98 yanchenglee98 commented Oct 27, 2020

Filtering residents by events. #135
E.g. filter-event 1 displays all residents attending the event 1 on the event list
Test cases for filter-event will be added in the future

image

@yanchenglee98 yanchenglee98 added this to the v1.3b milestone Oct 27, 2020
@yanchenglee98 yanchenglee98 self-assigned this Oct 27, 2020
@codecov-io
Copy link

codecov-io commented Oct 27, 2020

Codecov Report

Merging #147 into master will decrease coverage by 3.68%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #147      +/-   ##
============================================
- Coverage     67.38%   63.70%   -3.69%     
- Complexity      562      616      +54     
============================================
  Files            99      110      +11     
  Lines          1984     2229     +245     
  Branches        226      261      +35     
============================================
+ Hits           1337     1420      +83     
- Misses          542      707     +165     
+ Partials        105      102       -3     
Impacted Files Coverage Δ Complexity Δ
...edu/address/logic/commands/FilterEventCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../seedu/address/logic/parser/AddressBookParser.java 68.00% <0.00%> (-9.28%) 13.00 <0.00> (ø)
...address/logic/parser/FilterEventCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...eedu/address/model/event/FilterEventPredicate.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../seedu/address/logic/parser/FindCommandParser.java 63.88% <0.00%> (-23.99%) 10.00% <0.00%> (-1.00%)
...in/java/seedu/address/logic/parser/ParserUtil.java 60.74% <0.00%> (-8.99%) 25.00% <0.00%> (+4.00%) ⬇️
...n/java/seedu/address/storage/JsonAdaptedEvent.java 40.00% <0.00%> (-8.72%) 4.00% <0.00%> (+1.00%) ⬇️
...rc/main/java/seedu/address/model/person/Block.java 72.72% <0.00%> (-3.47%) 9.00% <0.00%> (ø%)
...u/address/storage/JsonSerializableAddressBook.java 88.23% <0.00%> (-3.44%) 8.00% <0.00%> (+3.00%) ⬇️
src/main/java/seedu/address/model/person/Room.java 58.06% <0.00%> (-1.20%) 12.00% <0.00%> (+4.00%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5354710...0eaa5f4. Read the comment docs.

Copy link

@athuyaoo athuyaoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM small nit pick

Copy link

@athuyaoo athuyaoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@athuyaoo athuyaoo merged commit 781b91c into AY2021S1-CS2103T-T11-2:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants