Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more validation checks for block and room related functions #219

Merged

Conversation

schoolex
Copy link

@schoolex schoolex commented Nov 1, 2020

closes #211
closes #205
closes #196

@schoolex schoolex added the type.Bug A bug found in the application label Nov 1, 2020
@schoolex schoolex added this to the v1.4 milestone Nov 1, 2020
@schoolex schoolex self-assigned this Nov 1, 2020
Copy link

@teekoksiang teekoksiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM, some boundary cases need to be handled.

@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #219 into master will decrease coverage by 0.96%.
The diff coverage is 29.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #219      +/-   ##
============================================
- Coverage     63.56%   62.59%   -0.97%     
- Complexity      619      621       +2     
============================================
  Files           110      110              
  Lines          2234     2275      +41     
  Branches        263      274      +11     
============================================
+ Hits           1420     1424       +4     
- Misses          708      738      +30     
- Partials        106      113       +7     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 72.09% <0.00%> (-9.49%) 13.00 <0.00> (ø)
...rc/main/java/seedu/address/model/person/Block.java 72.72% <ø> (ø) 10.00 <0.00> (ø)
src/main/java/seedu/address/model/UserPrefs.java 65.26% <30.76%> (-25.51%) 22.00 <1.00> (+2.00) ⬇️
...a/seedu/address/logic/parser/AddCommandParser.java 85.18% <42.85%> (-14.82%) 5.00 <0.00> (ø)
src/main/java/seedu/address/model/person/Room.java 58.06% <100.00%> (ø) 14.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fcf740...8d096b2. Read the comment docs.

Copy link

@teekoksiang teekoksiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! LGTM.

@teekoksiang teekoksiang merged commit a0694db into AY2021S1-CS2103T-T11-2:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Bug A bug found in the application
Projects
None yet
3 participants