-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more validation checks for block and room related functions #219
Add more validation checks for block and room related functions #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM, some boundary cases need to be handled.
…into blockRoomSettings-Branch
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
============================================
- Coverage 63.56% 62.59% -0.97%
- Complexity 619 621 +2
============================================
Files 110 110
Lines 2234 2275 +41
Branches 263 274 +11
============================================
+ Hits 1420 1424 +4
- Misses 708 738 +30
- Partials 106 113 +7
Continue to review full report at Codecov.
|
…into blockRoomSettings-Branch
…x/tp into blockRoomSettings-Branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! LGTM.
closes #211
closes #205
closes #196