Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure unique matric number and room #226

Conversation

athuyaoo
Copy link

@athuyaoo athuyaoo commented Nov 4, 2020

If you enter a duplicate matric number or room, there'll be an error.

Closes #199, #195

@athuyaoo athuyaoo linked an issue Nov 4, 2020 that may be closed by this pull request
@athuyaoo athuyaoo added this to the v1.4 milestone Nov 4, 2020
@athuyaoo athuyaoo self-assigned this Nov 4, 2020
@athuyaoo athuyaoo linked an issue Nov 4, 2020 that may be closed by this pull request
Copy link

@schoolex schoolex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
You can merge it after resolving the conflicts

@athuyaoo athuyaoo force-pushed the ensure-uniqueness-of-rooms-and-matric-number branch from 95cebc8 to 726703d Compare November 5, 2020 09:41
@codecov-io
Copy link

Codecov Report

Merging #226 into master will decrease coverage by 0.09%.
The diff coverage is 52.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #226      +/-   ##
============================================
- Coverage     67.69%   67.60%   -0.10%     
- Complexity      666      674       +8     
============================================
  Files           110      110              
  Lines          2294     2315      +21     
  Branches        282      289       +7     
============================================
+ Hits           1553     1565      +12     
- Misses          607      612       +5     
- Partials        134      138       +4     
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/AddCommand.java 75.00% <0.00%> (-25.00%) 8.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...java/seedu/address/logic/commands/EditCommand.java 90.81% <28.57%> (-4.79%) 14.00 <0.00> (+2.00) ⬇️
...rc/main/java/seedu/address/model/ModelManager.java 94.28% <90.00%> (-0.72%) 33.00 <5.00> (+5.00) ⬇️
src/main/java/seedu/address/model/person/Room.java 61.29% <0.00%> (+3.22%) 15.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fba4c2...726703d. Read the comment docs.

@athuyaoo athuyaoo merged commit 73f998d into AY2021S1-CS2103T-T11-2:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants