Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-functional requirements #25

Conversation

athuyaoo
Copy link

@athuyaoo athuyaoo commented Sep 26, 2020

Closes #25

@athuyaoo athuyaoo added the type.Task Not a story, bug, or an epic. label Sep 26, 2020
@athuyaoo athuyaoo added this to the v1.1 milestone Sep 26, 2020
@athuyaoo athuyaoo self-assigned this Sep 26, 2020
Copy link

@schoolex schoolex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor phrasing bugs

@@ -294,8 +294,11 @@ Priorities: High (must have) - `* * *`, Medium (nice to have) - `* *`, Low (unli
1. Should work on any _mainstream OS_ as long as it has Java `11` or above installed.
2. Should be able to hold up to 1000 persons without a noticeable sluggishness in performance for typical usage.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be persons?

Copy link

@schoolex schoolex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schoolex schoolex merged commit 9a50022 into AY2021S1-CS2103T-T11-2:master Sep 26, 2020
@athuyaoo athuyaoo mentioned this pull request Sep 26, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Task Not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants