-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matriculation number #66
Add matriculation number #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Apart from some straggling debug statements and nits, work is of top quality. 👍
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
============================================
- Coverage 72.31% 70.39% -1.92%
- Complexity 400 413 +13
============================================
Files 70 73 +3
Lines 1228 1314 +86
Branches 124 136 +12
============================================
+ Hits 888 925 +37
- Misses 308 353 +45
- Partials 32 36 +4
Continue to review full report at Codecov.
|
Show matriculation number in the resident list
Display error when the matriculation number is invalid