Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matriculation number #66

Merged

Conversation

teekoksiang
Copy link

@teekoksiang teekoksiang commented Oct 8, 2020

  • Add and edit matriculation number of a resident.
  • Display the matriculation number of residents.
  • Add MatriculationNumber unit test.

Show matriculation number in the resident list
Screenshot 2020-10-10 at 1 26 53 PM

Display error when the matriculation number is invalid
Screenshot 2020-10-10 at 1 29 22 PM

@teekoksiang teekoksiang added priority.High Must do type.Task Not a story, bug, or an epic. labels Oct 8, 2020
@teekoksiang teekoksiang added this to the v1.2 milestone Oct 8, 2020
@teekoksiang teekoksiang self-assigned this Oct 8, 2020
@teekoksiang teekoksiang linked an issue Oct 8, 2020 that may be closed by this pull request
3 tasks
Copy link

@yanchenglee98 yanchenglee98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Apart from some straggling debug statements and nits, work is of top quality. 👍

src/main/java/seedu/address/logic/parser/ParserUtil.java Outdated Show resolved Hide resolved
src/test/java/seedu/address/testutil/TypicalPersons.java Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #66 into master will decrease coverage by 1.91%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #66      +/-   ##
============================================
- Coverage     72.31%   70.39%   -1.92%     
- Complexity      400      413      +13     
============================================
  Files            70       73       +3     
  Lines          1228     1314      +86     
  Branches        124      136      +12     
============================================
+ Hits            888      925      +37     
- Misses          308      353      +45     
- Partials         32       36       +4     
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
.../java/seedu/address/model/util/SampleDataUtil.java 20.00% <0.00%> (ø) 1.00 <0.00> (ø)
src/main/java/seedu/address/ui/PersonCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...eedu/address/model/person/MatriculationNumber.java 80.00% <80.00%> (ø) 6.00 <6.00> (?)
...c/main/java/seedu/address/model/person/Person.java 95.74% <81.81%> (-1.82%) 23.00 <1.00> (+2.00) ⬇️
...java/seedu/address/logic/commands/EditCommand.java 95.94% <90.00%> (-1.07%) 12.00 <0.00> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...ain/java/seedu/address/logic/parser/CliSyntax.java 85.71% <100.00%> (+2.38%) 1.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 93.10% <100.00%> (+0.79%) 12.00 <0.00> (+1.00)
...in/java/seedu/address/logic/parser/ParserUtil.java 97.56% <100.00%> (+0.33%) 16.00 <2.00> (+2.00)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2d91bf...17fc536. Read the comment docs.

@yanchenglee98 yanchenglee98 merged commit e1eaae1 into AY2021S1-CS2103T-T11-2:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Task Not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add matriculation number
3 participants