Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional threshold for budgets #128

Merged

Conversation

wenhaogoh
Copy link

Closes #109

@wenhaogoh wenhaogoh requested review from a team and yu-ming-chen and removed request for a team October 17, 2020 16:41
@codecov-io
Copy link

Codecov Report

Merging #128 into master will decrease coverage by 1.29%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #128      +/-   ##
============================================
- Coverage     28.72%   27.42%   -1.30%     
+ Complexity      161      158       -3     
============================================
  Files            84       85       +1     
  Lines          1309     1338      +29     
  Branches         97      100       +3     
============================================
- Hits            376      367       -9     
- Misses          906      946      +40     
+ Partials         27       25       -2     
Impacted Files Coverage Δ Complexity Δ
...dress/logic/commands/main/CreateBudgetCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 34.09% <0.00%> (-4.38%) 6.00 <0.00> (ø)
...rser/mainpageparser/CreateBudgetCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/seedu/address/model/budget/Budget.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ain/java/seedu/address/model/budget/Threshold.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../java/seedu/address/storage/JsonAdaptedBudget.java 0.00% <0.00%> (-34.79%) 0.00 <0.00> (-2.00)
src/main/java/seedu/address/model/budget/Name.java 0.00% <0.00%> (-10.00%) 0.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb80092...463add6. Read the comment docs.

Copy link

@yu-ming-chen yu-ming-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenhaogoh wenhaogoh merged commit 25c0da6 into AY2021S1-CS2103T-T11-4:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional threshold for budgets
3 participants