Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'sort' command for budget page parser #141

Conversation

yu-ming-chen
Copy link

No description provided.

@yu-ming-chen yu-ming-chen added the priority.Medium Nice to have label Oct 19, 2020
@yu-ming-chen yu-ming-chen added this to the v1.3 milestone Oct 19, 2020
@yu-ming-chen yu-ming-chen requested a review from a team October 19, 2020 07:14
@yu-ming-chen yu-ming-chen self-assigned this Oct 19, 2020
@yu-ming-chen yu-ming-chen requested review from wenhaogoh and removed request for a team October 19, 2020 07:14
@yu-ming-chen yu-ming-chen linked an issue Oct 19, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #141 into master will decrease coverage by 0.27%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #141      +/-   ##
============================================
- Coverage     32.34%   32.07%   -0.28%     
  Complexity      193      193              
============================================
  Files            94       96       +2     
  Lines          1416     1428      +12     
  Branches        111      111              
============================================
  Hits            458      458              
- Misses          914      926      +12     
  Partials         44       44              
Impacted Files Coverage Δ Complexity Δ
.../logic/commands/budget/SortExpenditureCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ogic/parser/budgetpageparser/BudgetPageParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/model/Nusave.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/seedu/address/model/SortExpendituresByName.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54e5ce2...ed6df31. Read the comment docs.

wenhaogoh
wenhaogoh previously approved these changes Oct 19, 2020
Copy link

@wenhaogoh wenhaogoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@wenhaogoh wenhaogoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yu-ming-chen yu-ming-chen merged commit 3592962 into AY2021S1-CS2103T-T11-4:master Oct 20, 2020
@yu-ming-chen yu-ming-chen deleted the branch-addBugdetPageSortCommand branch October 20, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for 'sort' command for budget page parser
3 participants