Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Title on page change #78

Merged
merged 8 commits into from
Oct 14, 2020

Conversation

sogggy
Copy link

@sogggy sogggy commented Oct 13, 2020

No description provided.

@sogggy sogggy added the priority.High Must do label Oct 13, 2020
@sogggy sogggy added this to the v1.2 milestone Oct 13, 2020
@sogggy sogggy self-assigned this Oct 13, 2020
@sogggy sogggy linked an issue Oct 13, 2020 that may be closed by this pull request
@sogggy
Copy link
Author

sogggy commented Oct 13, 2020

Close #80

@codecov-io
Copy link

codecov-io commented Oct 14, 2020

Codecov Report

Merging #78 into master will decrease coverage by 0.73%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #78      +/-   ##
============================================
- Coverage     25.81%   25.07%   -0.74%     
  Complexity      144      144              
============================================
  Files            83       84       +1     
  Lines          1263     1300      +37     
  Branches         96       97       +1     
============================================
  Hits            326      326              
- Misses          916      953      +37     
  Partials         21       21              
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/seedu/address/logic/LogicManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ress/logic/commands/budget/CloseBudgetCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...address/logic/commands/main/OpenBudgetCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/model/Nusave.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/seedu/address/model/budget/BudgetList.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/state/PageTitle.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...rc/main/java/seedu/address/state/StateManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 805e12a...a988e62. Read the comment docs.

Copy link

@wenhaogoh wenhaogoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@davidliew9 davidliew9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidliew9 davidliew9 merged commit e38486a into AY2021S1-CS2103T-T11-4:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change UI title according to page
4 participants