Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch v1.2 #100

Merged
merged 6 commits into from
Oct 11, 2020
Merged

Conversation

wengfaing
Copy link

  • fix remove more quantity than existing item
  • add new optional field: metric
  • add test cases for metric

@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #100 into master will decrease coverage by 0.31%.
The diff coverage is 57.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
- Coverage     67.89%   67.57%   -0.32%     
- Complexity      416      430      +14     
============================================
  Files            76       77       +1     
  Lines          1411     1462      +51     
  Branches        145      154       +9     
============================================
+ Hits            958      988      +30     
- Misses          408      429      +21     
  Partials         45       45              
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <ø> (ø) 9.00 <0.00> (ø)
...va/seedu/address/logic/commands/RemoveCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 73.33% <0.00%> (-8.15%) 10.00 <0.00> (ø)
...c/main/java/seedu/address/model/item/Quantity.java 73.33% <ø> (ø) 8.00 <0.00> (ø)
.../java/seedu/address/model/util/SampleDataUtil.java 27.27% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/seedu/address/ui/ItemCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 87.80% <60.00%> (-3.87%) 14.00 <1.00> (+1.00) ⬇️
src/main/java/seedu/address/model/item/Metric.java 63.63% <63.63%> (ø) 3.00 <3.00> (?)
...java/seedu/address/logic/commands/EditCommand.java 96.05% <100.00%> (+0.40%) 14.00 <1.00> (+1.00)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø) 7.00 <0.00> (+1.00)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f566c83...5782f1c. Read the comment docs.

@@ -30,6 +32,7 @@
.map(JsonAdaptedTag::new)
.collect(Collectors.toList());
private static final String VALID_MAX_QUANTITY = DUCK.getMaxQuantity().toString();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be .getMaxQuantity().get().toString()
because .getMaxQuantity() returns Optional<Quantity>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. MaxQuantity is an Optional

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest commit. Thanks all

Copy link

@Choo-Xing-Yu Choo-Xing-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nicely done with the addition of metric variable

@Choo-Xing-Yu Choo-Xing-Yu merged commit 5fe69b5 into AY2021S1-CS2103T-T12-1:master Oct 11, 2020
@wengfaing wengfaing added this to the v1.2 milestone Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants