-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch v1.2 #100
Branch v1.2 #100
Conversation
wengfaing
commented
Oct 11, 2020
- fix remove more quantity than existing item
- add new optional field: metric
- add test cases for metric
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
============================================
- Coverage 67.89% 67.57% -0.32%
- Complexity 416 430 +14
============================================
Files 76 77 +1
Lines 1411 1462 +51
Branches 145 154 +9
============================================
+ Hits 958 988 +30
- Misses 408 429 +21
Partials 45 45
Continue to review full report at Codecov.
|
@@ -30,6 +32,7 @@ | |||
.map(JsonAdaptedTag::new) | |||
.collect(Collectors.toList()); | |||
private static final String VALID_MAX_QUANTITY = DUCK.getMaxQuantity().toString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be .getMaxQuantity().get().toString()
because .getMaxQuantity() returns Optional<Quantity>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. MaxQuantity is an Optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in latest commit. Thanks all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nicely done with the addition of metric variable