-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remove command #71
Add remove command #71
Conversation
Update from organization repo
@wengfaing do you want to add the relevant unit/ integration tests first for this command? Including parser for the command, logic, etc. Or do you prefer to do these tests in next iteration? |
I think i'll work on it in the next iteration! |
Sure, LGTM for this implementation! We can make the remove unit tests' tasks during next iteration |
/** | ||
* subtracts a Quantity's value from another quantity's value | ||
* @param quantity another quantity | ||
* @return Difference in Quantity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I rmb correctly, the following word after @return it should be the type, then description for subsequent words
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok fixed in latest commit
No description provided.