Branch max quantity tests #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from organization repo
PR from organization repo
Organization PR
Fix when toAdd item does not have maxQuantity and exisitingItem does it'll replace existingItem maxQuantity.
docs/UserGuide.md
Outdated
| @@ -102,7 +102,7 @@ Format: `list` | |||
|
|
|||
| Edits an existing item in the Inventory book. | |||
|
|
|||
| Format: ` edit INDEX n/NAME q/QUANTITY s/SUPPLIER [t/TAG]…` | |||
| Format: ` edit INDEX n/NAME q/QUANTITY s/SUPPLIER [max/MAX_QUANTITY] [t/TAG]…` | |||
There was a problem hiding this comment.
I think all the arguments, except INDEX, should be optional here
There was a problem hiding this comment.
Fixed! thanks for pointing it out!
docs/UserGuide.md
Outdated
| |**Clear** | `clear` | | ||
| |**Delete** | `delete INDEX`<br> e.g., `delete 3` | | ||
| |**Edit** | ` edit INDEX n/NAME q/QUANTITY s/SUPPLIER [t/TAG]…`<br> e.g.,`edit 1 n/Chicken q/50` | | ||
| |**Edit** | `edit INDEX n/NAME q/QUANTITY s/SUPPLIER [max/MAX_QUANTITY] [t/TAG]…`<br> e.g.,`edit 1 n/Chicken q/50` | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate max quantity into test cases.
Add new test cases to test max quantity
Fix typical items and related test cases.
Previously DUCK item had POULTRY tagged to it.
Fix bug where adding new item without max quantity tag will delete existing item max quantity tag
Update UG.
DG had nothing to be updated yet