Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic GUI for sales tracking section #103

Merged
merged 8 commits into from
Oct 21, 2020

Conversation

ureshiiYing
Copy link

Assertions and Logging has also been added at appropriate places.

@ureshiiYing ureshiiYing linked an issue Oct 21, 2020 that may be closed by this pull request
@ureshiiYing ureshiiYing added this to the v1.3 milestone Oct 21, 2020
@ureshiiYing ureshiiYing self-assigned this Oct 21, 2020
@codecov-io
Copy link

codecov-io commented Oct 21, 2020

Codecov Report

Merging #103 into master will decrease coverage by 0.70%.
The diff coverage is 21.27%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #103      +/-   ##
============================================
- Coverage     65.03%   64.33%   -0.71%     
- Complexity      613      617       +4     
============================================
  Files           110      111       +1     
  Lines          2105     2142      +37     
  Branches        246      258      +12     
============================================
+ Hits           1369     1378       +9     
- Misses          649      667      +18     
- Partials         87       97      +10     
Impacted Files Coverage Δ Complexity Δ
...address/logic/parser/SalesUpdateCommandParser.java 88.88% <0.00%> (-11.12%) 5.00 <0.00> (ø)
...ava/seedu/address/model/UniqueSalesRecordList.java 87.71% <0.00%> (-5.01%) 27.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/seedu/address/ui/SalesRecordEntryCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/java/seedu/address/ui/SalesRecordListPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/address/model/SalesBook.java 78.72% <42.85%> (-8.46%) 19.00 <1.00> (+1.00) ⬇️
...rc/main/java/seedu/address/model/ModelManager.java 73.11% <50.00%> (+0.29%) 34.00 <1.00> (+1.00)
...rc/main/java/seedu/address/logic/LogicManager.java 57.14% <100.00%> (+1.58%) 4.00 <1.00> (+1.00)
...seedu/address/logic/commands/SalesListCommand.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...edu/address/logic/commands/SalesUpdateCommand.java 100.00% <100.00%> (ø) 6.00 <0.00> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36aa41f...7dc01df. Read the comment docs.

Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanbingtao yanbingtao added priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic. labels Oct 21, 2020
Copy link

@WM71811 WM71811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanbingtao yanbingtao merged commit 2b37406 into master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement GUI for sales tracking
4 participants