Add sales find feature #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated version
… into branch-v1.3-DG-WangQian * 'branch-v1.3-DG-WangQian' of https://github.com/Persdre/tp: Update StorageClassDiagram.png Update JsonIngredientBookStorageTest.java Updated DG Update JsonIngredientBookStorageTest.java Update SetCommand.java Update diagram Update to pass CheckStyle Add more tests Add tests Implement Ingredient Storage Create IngredientListSequenceDiagram.puml Implement ingredient storage # Conflicts: # src/main/java/seedu/address/model/Model.java # src/main/java/seedu/address/model/UserPrefs.java
update it with latest version
Branch v1.3 dg wang qian
Persdre
added
priority.Medium
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
============================================
+ Coverage 62.17% 62.27% +0.10%
- Complexity 601 608 +7
============================================
Files 111 115 +4
Lines 2176 2203 +27
Branches 262 265 +3
============================================
+ Hits 1353 1372 +19
- Misses 733 738 +5
- Partials 90 93 +3
Continue to review full report at Codecov.
|
ureshiiYing
reviewed
Oct 27, 2020
docs/UserGuide.md
Outdated
| Format: `s-find KEYWORD [MORE_KEYWORDS]` | ||
|
|
||
| * The search is case-insensitive. e.g `bsbbt` will match `BSBBT`. | ||
| * Only the drink's short form name is searched. |
There was a problem hiding this comment.
Instead of saying short form name, abbreviation would be better.
docs/UserGuide.md
Outdated
| * The search is case-insensitive. e.g `bsbbt` will match `BSBBT`. | ||
| * Only the drink's short form name is searched. | ||
| * Only full words will be matched e.g. `BSB` will not match `BSBBT`. | ||
| * Drinks matching at least one keyword will be returned (i.e. `OR` search). |
There was a problem hiding this comment.
Saying OR search may not be that user-friendly?
There was a problem hiding this comment.
en, yes, I agree. I understand but maybe users' can't. I will give a concrete example in the bracket. Thanks~
docs/DeveloperGuide.md
Outdated
|
|
||
| ##### Aspect: How to find drink's sales data | ||
|
|
||
| * **Alternative 1 (current choice):** Obtain the drink's name entered by the user, and use the |
There was a problem hiding this comment.
Since you only stated one implementation, calling it Alternative 1 may not be that good? Since there was no other alternatives considered.
There was a problem hiding this comment.
hh ok I copied the format from original UG. I will delete alternative one here.
Comment on lines
62
to
71
| // @Test | ||
| // public void execute_multipleKeywords_multipleDrinksFound() { | ||
| // String expectedMessage = String.format(MESSAGE_DRINKS_LISTED_OVERVIEW, 3); | ||
| // InputContainsKeywordsPredicate predicate = preparePredicate("BSBMT BSPM BSBBT"); | ||
| // SalesFindCommand command = new SalesFindCommand(predicate); | ||
| // expectedModel.updateFilteredSalesList(predicate); | ||
| // assertCommandSuccess(command, model, expectedMessage, expectedModel); | ||
| // assertEquals(Arrays.asList(), model.getFilteredSalesRecordList()); | ||
| // } | ||
|
|
There was a problem hiding this comment.
Remember to delete this test if unused.
Update with the latest version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.