-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create c-tag-find/c-today/c-tomorrow feature #141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
============================================
- Coverage 63.57% 61.46% -2.11%
Complexity 665 665
============================================
Files 119 124 +5
Lines 2380 2473 +93
Branches 287 294 +7
============================================
+ Hits 1513 1520 +7
- Misses 755 841 +86
Partials 112 112
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other comments: Perhaps naming the commands as TodayCommand
and TomorrowCommand
isn't the best? It felt vague to me. The missing javadoc descriptions did not help too.
src/main/java/seedu/address/logic/commands/TomorrowCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/commands/TomorrowCommand.java
Outdated
Show resolved
Hide resolved
I've changed these two to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c-today
:c-tomorrow
:c-tag-find KEYWORD [KEYWORDS] ...