Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange warning messages. #157

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Conversation

yanbingtao
Copy link

No description provided.

@yanbingtao yanbingtao added the severity.VeryLow A flaw that is purely cosmetic and does not affect usage label Oct 28, 2020
@yanbingtao yanbingtao added this to the v1.3 milestone Oct 28, 2020
@yanbingtao yanbingtao self-assigned this Oct 28, 2020
@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@0d155e2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #157   +/-   ##
=========================================
  Coverage          ?   61.46%           
  Complexity        ?      665           
=========================================
  Files             ?      124           
  Lines             ?     2473           
  Branches          ?      294           
=========================================
  Hits              ?     1520           
  Misses            ?      841           
  Partials          ?      112           
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <ø> (ø) 8.00 <0.00> (?)
...seedu/address/logic/commands/SalesListCommand.java 100.00% <ø> (ø) 3.00 <0.00> (?)
src/main/java/seedu/address/model/tag/Tag.java 80.00% <0.00%> (ø) 5.00% <0.00%> (?%)
...seedu/address/logic/commands/UnarchiveCommand.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...u/address/logic/parser/UnarchiveCommandParser.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...ands/ingredientcommands/IngredientListCommand.java 100.00% <0.00%> (ø) 6.00% <0.00%> (?%)
...edient/exceptions/IngredientNotFoundException.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
src/main/java/seedu/address/ui/PersonCard.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...eedu/address/logic/parser/SetAllCommandParser.java 100.00% <0.00%> (ø) 5.00% <0.00%> (?%)
... and 116 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d155e2...eb33ae8. Read the comment docs.

Copy link

@Diwu-Yi Diwu-Yi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@WM71811 WM71811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Persdre Persdre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Persdre Persdre merged commit a9f6ea6 into master Oct 28, 2020
Copy link

@ureshiiYing ureshiiYing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity.VeryLow A flaw that is purely cosmetic and does not affect usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants