Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SalesRankCommand which ranks the list of drinks in Sales Tracker #170

Merged
merged 12 commits into from
Oct 29, 2020
Merged

Add SalesRankCommand which ranks the list of drinks in Sales Tracker #170

merged 12 commits into from
Oct 29, 2020

Conversation

ureshiiYing
Copy link

@ureshiiYing ureshiiYing commented Oct 29, 2020 •
edited

The following has been done:

  • Implement functionality for ranking drink sales records
  • Add tests for the above
  • Fix a minor bug in UniqueSalesRecordList
  • Update UG

@ureshiiYing ureshiiYing added type.Story A user story priority.Medium Nice to have labels Oct 29, 2020
@ureshiiYing ureshiiYing added this to the v1.4 milestone Oct 29, 2020
@ureshiiYing ureshiiYing self-assigned this Oct 29, 2020
@ureshiiYing ureshiiYing linked an issue Oct 29, 2020 that may be closed by this pull request
As an intermediate user, I want to see a ranking of the drinks sold, ... #160
Closed
yanbingtao
yanbingtao previously approved these changes Oct 29, 2020
View reviewed changes
Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Oct 29, 2020 •
edited

Codecov Report

Merging #170 into master will decrease coverage by 0.31%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #170      +/-   ##
============================================
- Coverage     61.46%   61.14%   -0.32%     
- Complexity      665      687      +22     
============================================
  Files           124      125       +1     
  Lines          2473     2579     +106     
  Branches        294      321      +27     
============================================
+ Hits           1520     1577      +57     
- Misses          841      889      +48     
- Partials        112      113       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...seedu/address/logic/commands/SalesListCommand.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 59.25% <ø> (+4.25%) 6.00 <0.00> (+2.00)
...seedu/address/logic/commands/SalesRankCommand.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
.../seedu/address/logic/parser/AddressBookParser.java 62.85% <100.00%> (+1.09%) 18.00 <0.00> (+1.00)
...rc/main/java/seedu/address/model/ModelManager.java 79.78% <100.00%> (+0.43%) 37.00 <1.00> (+1.00)
src/main/java/seedu/address/model/SalesBook.java 90.69% <100.00%> (+10.20%) 20.00 <1.00> (+3.00)
...ava/seedu/address/model/UniqueSalesRecordList.java 91.93% <100.00%> (+4.21%) 29.00 <3.00> (+2.00)
...ngredientcommands/IngredientViewSingleCommand.java 61.70% <0.00%> (-4.97%) 13.00% <0.00%> (+6.00%) ⬇️
...s/ingredientcommands/IngredientRestockCommand.java 58.33% <0.00%> (-0.50%) 4.00% <0.00%> (+1.00%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e390bc8...78698ca. Read the comment docs.

yanbingtao
yanbingtao approved these changes Oct 29, 2020
View reviewed changes
Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

WM71811
WM71811 approved these changes Oct 29, 2020
View reviewed changes
Copy link

@WM71811 WM71811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanbingtao yanbingtao merged commit e2d2a11 into master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WM71811 WM71811 WM71811 approved these changes

@yanbingtao yanbingtao yanbingtao approved these changes

Assignees

@ureshiiYing ureshiiYing

Labels
priority.Medium Nice to have type.Story A user story
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

As an intermediate user, I want to see a ranking of the drinks sold, ...
4 participants
@ureshiiYing @codecov-io @WM71811 @yanbingtao