Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the sales bugs reported in issues #235

Merged
merged 14 commits into from
Nov 7, 2020
Merged

Conversation

ureshiiYing
Copy link

The following has been fixed and updated:

  • Sales Rank and Sales List command has been merged into one feature - now Sales List will show a ranked list instead.
  • Added a cap to the maximum amount that sales update command can set (9,999,999)
  • Update the UG to match these changes
  • Added instructions to the examples in the UG sales commands

Additionally, UG has been updated to match the change.
Additionally,
* Updated the UG to match the changes
* Added and updated tests to match the changes in logic of the code
@ureshiiYing ureshiiYing added this to the v1.4 milestone Nov 4, 2020
@ureshiiYing ureshiiYing self-assigned this Nov 4, 2020
@codecov-io
Copy link

codecov-io commented Nov 5, 2020

Codecov Report

Merging #235 (38688f8) into master (2771ca0) will increase coverage by 0.22%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #235      +/-   ##
============================================
+ Coverage     66.42%   66.65%   +0.22%     
- Complexity      736      738       +2     
============================================
  Files           125      124       -1     
  Lines          2487     2498      +11     
  Branches        312      315       +3     
============================================
+ Hits           1652     1665      +13     
+ Misses          713      710       -3     
- Partials        122      123       +1     
Impacted Files Coverage Δ Complexity Δ
.../seedu/address/logic/parser/AddressBookParser.java 61.76% <ø> (-1.10%) 17.00 <0.00> (-1.00)
src/main/java/seedu/address/model/Drink.java 90.47% <ø> (ø) 8.00 <0.00> (ø)
...in/java/seedu/address/commons/util/StringUtil.java 93.10% <80.00%> (-2.73%) 11.00 <1.00> (+1.00) ⬇️
...seedu/address/logic/commands/SalesListCommand.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...edu/address/logic/commands/SalesUpdateCommand.java 100.00% <100.00%> (ø) 6.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 77.77% <100.00%> (+0.72%) 20.00 <0.00> (+1.00)
...address/logic/parser/SalesUpdateCommandParser.java 82.35% <100.00%> (+2.35%) 7.00 <0.00> (+1.00)
src/main/java/seedu/address/model/SalesBook.java 91.30% <100.00%> (ø) 21.00 <0.00> (ø)
...ava/seedu/address/model/UniqueSalesRecordList.java 92.30% <100.00%> (+0.37%) 30.00 <1.00> (+1.00)
...rc/main/java/seedu/address/model/ModelManager.java 84.44% <0.00%> (+3.33%) 37.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2771ca0...38688f8. Read the comment docs.

docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Show resolved Hide resolved
WM71811
WM71811 previously approved these changes Nov 7, 2020
Copy link

@WM71811 WM71811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@WM71811 WM71811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanbingtao yanbingtao merged commit 07ed8a2 into master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment