-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the sales bugs reported in issues #235
Conversation
Additionally, UG has been updated to match the change.
Additionally, * Updated the UG to match the changes * Added and updated tests to match the changes in logic of the code
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
============================================
+ Coverage 66.42% 66.65% +0.22%
- Complexity 736 738 +2
============================================
Files 125 124 -1
Lines 2487 2498 +11
Branches 312 315 +3
============================================
+ Hits 1652 1665 +13
+ Misses 713 710 -3
- Partials 122 123 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…1S1-CS2103T-T12-2/tp into branch-v1.4-salesBugFix-yh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The following has been fixed and updated: