Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UG , DG and improve error message #254

Merged

Conversation

Diwu-Yi
Copy link

@Diwu-Yi Diwu-Yi commented Nov 5, 2020

No description provided.

@Diwu-Yi Diwu-Yi self-assigned this Nov 5, 2020
@Diwu-Yi Diwu-Yi added the documentation Improvements or additions to documentation label Nov 5, 2020
@Diwu-Yi Diwu-Yi added this to the v1.4 milestone Nov 5, 2020
@codecov-io
Copy link

codecov-io commented Nov 5, 2020

Codecov Report

Merging #254 (35861c5) into master (9f5f3de) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #254   +/-   ##
=========================================
  Coverage     66.65%   66.65%           
  Complexity      738      738           
=========================================
  Files           124      124           
  Lines          2498     2498           
  Branches        315      315           
=========================================
  Hits           1665     1665           
  Misses          710      710           
  Partials        123      123           
Impacted Files Coverage Δ Complexity Δ
...in/java/seedu/address/logic/parser/ParserUtil.java 77.77% <ø> (ø) 20.00 <0.00> (ø)
.../main/java/seedu/address/model/IngredientBook.java 88.88% <100.00%> (ø) 12.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 84.44% <100.00%> (ø) 37.00 <1.00> (ø)
src/main/java/seedu/address/model/Model.java 40.74% <0.00%> (ø) 5.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5f3de...35861c5. Read the comment docs.

docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Show resolved Hide resolved
@Diwu-Yi Diwu-Yi changed the title Update UG and improve error message Update UG , DG and improve error message Nov 6, 2020
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
Copy link

@ureshiiYing ureshiiYing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised I did not review your DG, so I have done it now.

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Show resolved Hide resolved
docs/UserGuide.md Show resolved Hide resolved
docs/UserGuide.md Show resolved Hide resolved
Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Persdre Persdre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/UserGuide.md Outdated Show resolved Hide resolved
@yanbingtao yanbingtao merged commit b14d879 into AY2021S1-CS2103T-T12-2:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants