Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete employees' email detail for future update in emergency contact #63

Merged
merged 18 commits into from
Oct 7, 2020
Merged

Delete employees' email detail for future update in emergency contact #63

merged 18 commits into from
Oct 7, 2020

Conversation

Persdre
Copy link

@Persdre Persdre commented Oct 6, 2020

For a future update in emergency contact

@Persdre Persdre changed the title Branch v1.2 edit wang qian [Don't review now] Branch v1.2 edit wang qian Oct 6, 2020
@Persdre Persdre changed the title [Don't review now] Branch v1.2 edit wang qian [Don't review now] Change edit command Oct 6, 2020
@Persdre Persdre self-assigned this Oct 7, 2020
@Persdre Persdre added this to the v1.2 milestone Oct 7, 2020
@Persdre Persdre added priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic. labels Oct 7, 2020
@Persdre Persdre changed the title [Don't review now] Change edit command [Don't review now] Delete email in edit command Oct 7, 2020
@Persdre Persdre changed the title [Don't review now] Delete email in edit command Delete email in edit command Oct 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #63 into master will decrease coverage by 0.62%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #63      +/-   ##
============================================
- Coverage     72.48%   71.86%   -0.63%     
+ Complexity      400      386      -14     
============================================
  Files            70       69       -1     
  Lines          1225     1187      -38     
  Branches        124      117       -7     
============================================
- Hits            888      853      -35     
+ Misses          305      303       -2     
+ Partials         32       31       -1
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...ain/java/seedu/address/logic/parser/CliSyntax.java 80.00% <ø> (-3.34%) 1.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 96.77% <ø> (-0.45%) 12.00 <0.00> (-2.00)
.../main/java/seedu/address/model/person/Address.java 80.00% <ø> (ø) 6.00 <0.00> (ø)
.../java/seedu/address/model/util/SampleDataUtil.java 20.00% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/seedu/address/ui/PersonCard.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...c/main/java/seedu/address/model/person/Person.java 97.22% <75.00%> (-0.34%) 18.00 <0.00> (-3.00)
...java/seedu/address/logic/commands/EditCommand.java 96.72% <100.00%> (-0.30%) 12.00 <0.00> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 91.66% <100.00%> (-0.65%) 10.00 <0.00> (-1.00)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f1893...0a35c7f. Read the comment docs.

@Persdre Persdre changed the title Delete email in edit command Delete email in the contact information Oct 7, 2020
ureshiiYing
ureshiiYing previously approved these changes Oct 7, 2020
View reviewed changes
Copy link

@ureshiiYing ureshiiYing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. I don't think you need to remove the email information under tutorial documentation. However, this does not affect the app, so perhaps it is fine.

@Persdre Persdre changed the title Delete email in the contact information Edit employees' contact detail Oct 7, 2020
@Persdre Persdre changed the title Edit employees' contact detail Delete employees' email detail for future update in emergency contact Oct 7, 2020
@Persdre Persdre linked an issue Oct 7, 2020 that may be closed by this pull request
As an intermidiate user, I can edit my employees' contact details #47
Closed
yanbingtao
yanbingtao approved these changes Oct 7, 2020
View reviewed changes
Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ureshiiYing
ureshiiYing approved these changes Oct 7, 2020
View reviewed changes
Copy link

@ureshiiYing ureshiiYing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Persdre Persdre merged commit bd0d01b into AY2021S1-CS2103T-T12-2:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanbingtao yanbingtao yanbingtao approved these changes

@ureshiiYing ureshiiYing ureshiiYing approved these changes

Assignees

@Persdre Persdre

Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

As an intermidiate user, I can edit my employees' contact details
4 participants
@Persdre @codecov-io @yanbingtao @ureshiiYing