Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement parser support and functionality for updating the sales of drink items #65

Merged

Conversation

ureshiiYing
Copy link

@ureshiiYing ureshiiYing commented Oct 6, 2020

Implementing parser support first serves as foundation to implement the sales command feature, which updates and tracks the sales of drinks.

Functionality of updating drink sales has also been implemented. There are 6 drink types that the user can update.

However, these data are only stored in memory and has not been implemented to be stored locally. The UI for sales tracking has also not been implemented. Currently, the ResultDisplay is used to show the sales data.

@ureshiiYing ureshiiYing added type.Task Something that needs to be done, but not a story, bug, or an epic. priority.High Must do labels Oct 6, 2020
@ureshiiYing ureshiiYing added this to the v1.2 milestone Oct 6, 2020
@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6e8aa44). Click here to learn what that means.
The diff coverage is 94.25%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #65   +/-   ##
=========================================
  Coverage          ?   73.92%           
  Complexity        ?      434           
=========================================
  Files             ?       74           
  Lines             ?     1308           
  Branches          ?      131           
=========================================
  Hits              ?      967           
  Misses            ?      309           
  Partials          ?       32           
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (?)
...rc/main/java/seedu/address/model/ModelManager.java 96.42% <83.33%> (ø) 27.00 <4.00> (?)
src/main/java/seedu/address/model/SalesBook.java 96.29% <96.29%> (ø) 15.00 <15.00> (?)
...edu/address/logic/commands/SalesUpdateCommand.java 100.00% <100.00%> (ø) 6.00 <6.00> (?)
.../seedu/address/logic/parser/AddressBookParser.java 100.00% <100.00%> (ø) 13.00 <0.00> (?)
...ain/java/seedu/address/logic/parser/CliSyntax.java 91.66% <100.00%> (ø) 1.00 <0.00> (?)
...address/logic/parser/SalesUpdateCommandParser.java 100.00% <100.00%> (ø) 6.00 <6.00> (?)
src/main/java/seedu/address/model/Drink.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e8aa44...ae4c0c4. Read the comment docs.

Note that the UI for sales tracking is not done yet. Thus, the result of the sales command will be displayed in the ResultDisplay instead.
Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ureshiiYing ureshiiYing changed the title Implement parser support for updating the sales of drink items Implement parser support and functionality for updating the sales of drink items Oct 7, 2020
Copy link

@Persdre Persdre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanbingtao yanbingtao merged commit da95159 into AY2021S1-CS2103T-T12-2:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing parser support and functionality for updating the sales of drink items
4 participants