Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add archive-list feature #67

Merged
merged 22 commits into from
Oct 14, 2020
Merged

Add archive-list feature #67

merged 22 commits into from
Oct 14, 2020

Conversation

yanbingtao
Copy link

@yanbingtao yanbingtao commented Oct 7, 2020 •
edited

  • Creates archiveStatus flag in the Model -> Person to show if the specific contact has been set as "archived".
  • Allows users to see all archived data when "archive list" command entered.
  • When a user tries to archive an already archived data, it will return an error.

@yanbingtao yanbingtao self-assigned this Oct 7, 2020
@yanbingtao yanbingtao added priority.Medium Nice to have type.Enhancement An enhancement to an existing story labels Oct 7, 2020
@yanbingtao yanbingtao added this to the v1.2 milestone Oct 7, 2020
@yanbingtao yanbingtao linked an issue Oct 7, 2020 that may be closed by this pull request
As a store manager, I can see all archived contact details #33
Closed
@yanbingtao yanbingtao added type.Task Something that needs to be done, but not a story, bug, or an epic. and removed type.Enhancement An enhancement to an existing story labels Oct 7, 2020
@yanbingtao yanbingtao changed the title Adds archive-list feature [Don't merge first] Adds archive-list feature Oct 7, 2020
@yanbingtao yanbingtao modified the milestones: v1.2, v1.2b Oct 7, 2020
@WM71811 WM71811 modified the milestones: v1.2b, v1.2 Oct 10, 2020
@yanbingtao yanbingtao changed the title [Don't merge first] Adds archive-list feature Adds archive-list feature Oct 13, 2020
@yanbingtao yanbingtao added type.Story A user story and removed type.Task Something that needs to be done, but not a story, bug, or an epic. labels Oct 14, 2020
Diwu-Yi
Diwu-Yi approved these changes Oct 14, 2020
View reviewed changes
Copy link

@Diwu-Yi Diwu-Yi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanbingtao yanbingtao merged commit c814520 into AY2021S1-CS2103T-T12-2:master Oct 14, 2020
@yanbingtao yanbingtao changed the title Adds archive-list feature Add archive-list feature Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ureshiiYing ureshiiYing ureshiiYing left review comments

@Diwu-Yi Diwu-Yi Diwu-Yi approved these changes

Assignees

@yanbingtao yanbingtao

Labels
priority.Medium Nice to have type.Story A user story
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

As a store manager, I can see all archived contact details
4 participants
@yanbingtao @Diwu-Yi @ureshiiYing @WM71811