Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement set all ingredients feature #82

Merged

Conversation

Diwu-Yi
Copy link

@Diwu-Yi Diwu-Yi commented Oct 14, 2020

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #82 into master will increase coverage by 1.86%.
The diff coverage is 85.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #82      +/-   ##
============================================
+ Coverage     69.21%   71.07%   +1.86%     
- Complexity      478      506      +28     
============================================
  Files            86       88       +2     
  Lines          1533     1594      +61     
  Branches        160      175      +15     
============================================
+ Hits           1061     1133      +72     
+ Misses          423      405      -18     
- Partials         49       56       +7     
Impacted Files Coverage Δ Complexity Δ
.../seedu/address/logic/parser/AddressBookParser.java 78.26% <0.00%> (-3.56%) 14.00 <0.00> (ø)
...va/seedu/address/logic/commands/SetAllCommand.java 77.77% <77.77%> (ø) 9.00 <9.00> (?)
...ain/java/seedu/address/logic/parser/CliSyntax.java 94.44% <100.00%> (+2.13%) 1.00 <0.00> (ø)
...eedu/address/logic/parser/SetAllCommandParser.java 100.00% <100.00%> (ø) 5.00 <5.00> (?)
.../main/java/seedu/address/model/IngredientBook.java 87.50% <100.00%> (+11.30%) 10.00 <2.00> (+2.00)
...ava/seedu/address/model/ingredient/Ingredient.java 77.41% <100.00%> (+27.41%) 11.00 <0.00> (+3.00)
...address/model/ingredient/UniqueIngredientList.java 59.37% <100.00%> (+9.37%) 11.00 <2.00> (+3.00)
...rc/main/java/seedu/address/model/ModelManager.java 94.44% <0.00%> (+2.77%) 32.00% <0.00%> (+1.00%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 174c671...5e0cec8. Read the comment docs.

Copy link

@Persdre Persdre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanbingtao yanbingtao merged commit 9ff4328 into AY2021S1-CS2103T-T12-2:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have type.Story A user story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a second-time user, I can set different ingredients levels to different specified amounts
4 participants