Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch v1.3 update dg zy #91

Merged
merged 7 commits into from
Oct 21, 2020
Merged

Branch v1.3 update dg zy #91

merged 7 commits into from
Oct 21, 2020

Conversation

Diwu-Yi
Copy link

@Diwu-Yi Diwu-Yi commented Oct 18, 2020

Add explanations, UML diagrams in progress.

@codecov-io
Copy link

codecov-io commented Oct 18, 2020 •
edited

Codecov Report

Merging #91 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #91   +/-   ##
=========================================
  Coverage     65.03%   65.03%           
  Complexity      613      613           
=========================================
  Files           110      110           
  Lines          2105     2105           
  Branches        246      246           
=========================================
  Hits           1369     1369           
  Misses          649      649           
  Partials         87       87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2ad37...eef8850. Read the comment docs.

@Diwu-Yi Diwu-Yi self-assigned this Oct 21, 2020
@Diwu-Yi Diwu-Yi added priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic. labels Oct 21, 2020
@Diwu-Yi Diwu-Yi added this to the v1.3 milestone Oct 21, 2020
@Diwu-Yi Diwu-Yi mentioned this pull request Oct 21, 2020
Closed
@Diwu-Yi
Copy link
Author

Diwu-Yi commented Oct 21, 2020

#97

yanbingtao
yanbingtao approved these changes Oct 21, 2020
View reviewed changes
Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yanbingtao
yanbingtao previously approved these changes Oct 21, 2020
View reviewed changes
Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Persdre
Persdre previously approved these changes Oct 21, 2020
View reviewed changes
Copy link

@Persdre Persdre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Diwu-Yi Diwu-Yi dismissed stale reviews from Persdre and yanbingtao via 641d5d9 October 21, 2020 11:08
yanbingtao
yanbingtao previously approved these changes Oct 21, 2020
View reviewed changes
Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

WM71811
WM71811 previously approved these changes Oct 21, 2020
View reviewed changes
Copy link

@WM71811 WM71811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Diwu-Yi Diwu-Yi dismissed stale reviews from WM71811 and yanbingtao via eef8850 October 21, 2020 13:22
yanbingtao
yanbingtao approved these changes Oct 21, 2020
View reviewed changes
Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Persdre
Persdre approved these changes Oct 21, 2020
View reviewed changes
Copy link

@Persdre Persdre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

WM71811
WM71811 approved these changes Oct 21, 2020
View reviewed changes
Copy link

@WM71811 WM71811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanbingtao yanbingtao merged commit 1927c36 into AY2021S1-CS2103T-T12-2:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Persdre Persdre Persdre approved these changes

@WM71811 WM71811 WM71811 approved these changes

@yanbingtao yanbingtao yanbingtao approved these changes

Assignees

@Diwu-Yi Diwu-Yi

Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Diwu-Yi @codecov-io @Persdre @WM71811 @yanbingtao