Marcus/Replace all instances of person with task #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcTzh
changed the title
docs/tutorials/AddRemark.md
Outdated
| @@ -308,9 +308,9 @@ Just add [this one line of code!](https://github.com/se-edu/addressbook-level3/c | |||
| **`PersonCard.java`:** | |||
|
|
|||
| ``` java | |||
| public PersonCard(Person person, int displayedIndex) { | |||
| public PersonCard(Person task, int displayedIndex) { | |||
There was a problem hiding this comment.
These are in addremark.md not actual code, not sure if it needs to be changed
There was a problem hiding this comment.
ok undid changes in these documents, please review again
docs/tutorials/AddRemark.md
Outdated
| Person personToEdit = lastShownList.get(index.getZeroBased()); | ||
| Person editedPerson = new Person(personToEdit.getName(), personToEdit.getPhone(), personToEdit.getEmail(), | ||
| personToEdit.getAddress(), remark, personToEdit.getTags()); | ||
| Person taskToEdit = lastShownList.get(index.getZeroBased()); |
There was a problem hiding this comment.
The class here is still not changed to Task
There was a problem hiding this comment.
ok undid changes in these documents, please review again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #99