-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zijian/change email to description #125
Zijian/change email to description #125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change one parameter, other than that looks good
src/test/data/JsonSerializableAddressBookTest/typicalTaskAddressBook.json
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
============================================
+ Coverage 72.31% 72.38% +0.06%
Complexity 400 400
============================================
Files 70 70
Lines 1228 1231 +3
Branches 124 124
============================================
+ Hits 888 891 +3
Misses 308 308
Partials 32 32
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment suggestion, other than that LGTM
fixes #119
Description field should not be empty, should not be blank or start with a blank. should contain only alphenumerical values, commas, periods, question marks or exclamation marks.