Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zijian/change email to description #125

Merged
merged 13 commits into from
Oct 3, 2020
Merged

Zijian/change email to description #125

merged 13 commits into from
Oct 3, 2020

Conversation

BobbyZhouZijian
Copy link

fixes #119

Description field should not be empty, should not be blank or start with a blank. should contain only alphenumerical values, commas, periods, question marks or exclamation marks.

@BobbyZhouZijian BobbyZhouZijian self-assigned this Oct 3, 2020
@BobbyZhouZijian BobbyZhouZijian added this to the v1.2 milestone Oct 3, 2020
Copy link

@MarcTzh MarcTzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change one parameter, other than that looks good

docs/tutorials/RemovingFields.md Outdated Show resolved Hide resolved
docs/tutorials/RemovingFields.md Outdated Show resolved Hide resolved
src/main/java/seedu/address/logic/parser/ParserUtil.java Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #125 into master will increase coverage by 0.06%.
The diff coverage is 92.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #125      +/-   ##
============================================
+ Coverage     72.31%   72.38%   +0.06%     
  Complexity      400      400              
============================================
  Files            70       70              
  Lines          1228     1231       +3     
  Branches        124      124              
============================================
+ Hits            888      891       +3     
  Misses          308      308              
  Partials         32       32              
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
.../java/seedu/address/model/util/SampleDataUtil.java 20.00% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/seedu/address/ui/TaskCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ain/java/seedu/address/model/task/Description.java 80.00% <80.00%> (ø) 6.00 <6.00> (?)
src/main/java/seedu/address/model/task/Task.java 97.56% <88.88%> (ø) 21.00 <1.00> (ø)
...java/seedu/address/logic/commands/EditCommand.java 97.01% <100.00%> (ø) 12.00 <0.00> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...ain/java/seedu/address/logic/parser/CliSyntax.java 83.33% <100.00%> (ø) 1.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 92.85% <100.00%> (+0.54%) 11.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 97.22% <100.00%> (ø) 14.00 <2.00> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2eb026...9afc0fe. Read the comment docs.

Copy link

@MarcTzh MarcTzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment suggestion, other than that LGTM

@BobbyZhouZijian BobbyZhouZijian merged commit 0279fb8 into AY2021S1-CS2103T-T12-3:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Email field to Description
3 participants