Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gangwei/Fix UI bug #133

Merged
merged 2 commits into from
Oct 11, 2020
Merged

Conversation

nuovonatura
Copy link

Ui crashes because the id for dateTime label is not updated.
In this commit, dateTime label is updated to the correct name.

Some code is reformated because of the use of scene builder.

Ui crashes because the id for dateTime label is not updated.
In this commit, dateTime label is updated to the correct name.
@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #133 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #133   +/-   ##
=========================================
  Coverage     71.94%   71.94%           
  Complexity      412      412           
=========================================
  Files            72       72           
  Lines          1276     1276           
  Branches        128      128           
=========================================
  Hits            918      918           
  Misses          323      323           
  Partials         35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da385e2...11a85ba. Read the comment docs.

Update Javafx version from 11.0.1 to 11.0.0.
Copy link

@BobbyZhouZijian BobbyZhouZijian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BobbyZhouZijian BobbyZhouZijian merged commit e122538 into AY2021S1-CS2103T-T12-3:master Oct 11, 2020
@nuovonatura nuovonatura changed the title Fix UI bug Gangwei/Fix UI bug Oct 12, 2020
@nuovonatura nuovonatura self-assigned this Oct 12, 2020
@nuovonatura nuovonatura added the priority.High Must do label Oct 12, 2020
@nuovonatura nuovonatura added this to the v1.2 milestone Oct 12, 2020
@nuovonatura nuovonatura added severity.High A flaw that affects most users and causes major problems for users. i.e., makes the product almost u type.Bug A bug and removed priority.High Must do labels Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity.High A flaw that affects most users and causes major problems for users. i.e., makes the product almost u type.Bug A bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants