-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zijian/implement find for status #161
Zijian/implement find for status #161
Conversation
Hi Zijian, I conducted some boundary value analysis and found that it works as intended for the positive test cases but when i put in find status: it does not throw any error, it says 0 tasks listed, following equivalence partitioning i shall stop further tests |
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
============================================
+ Coverage 73.39% 74.24% +0.84%
- Complexity 462 488 +26
============================================
Files 74 74
Lines 1421 1460 +39
Branches 159 168 +9
============================================
+ Hits 1043 1084 +41
+ Misses 332 330 -2
Partials 46 46
Continue to review full report at Codecov.
|
A few problems I found: Error message displayed should state that status can only be of 2 values: complete and incomplete.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor change, LGTM
for (Map.Entry<Prefix, List<String>> entry : keywords.entrySet()) { | ||
Prefix prefix = entry.getKey(); | ||
List<String> words = entry.getValue(); | ||
if (isMatched(prefix.getPrefix(), words, task)) { | ||
return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel the original code is correct?
Find now works for status.
Must search for the exact word of the status. E.g. "incomplete" will find all incomplete tasks, but "inc" will not match any.
Have not refactored the docs yet. Waiting for some kind guy to fix it. I'm too sleepy now and need to rest.
Fix #146
Fix #17