Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zijian/edit and delete for lesson #202

Merged
merged 12 commits into from
Oct 28, 2020
Merged

Conversation

BobbyZhouZijian
Copy link

fixes #16

@BobbyZhouZijian BobbyZhouZijian added this to the v1.3 milestone Oct 28, 2020
@BobbyZhouZijian BobbyZhouZijian self-assigned this Oct 28, 2020
@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #202 into master will decrease coverage by 2.30%.
The diff coverage is 10.32%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #202      +/-   ##
============================================
- Coverage     44.96%   42.65%   -2.31%     
- Complexity      545      547       +2     
============================================
  Files           106      112       +6     
  Lines          2522     2670     +148     
  Branches        344      377      +33     
============================================
+ Hits           1134     1139       +5     
- Misses         1281     1423     +142     
- Partials        107      108       +1     
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...du/address/logic/commands/DeleteLessonCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...java/seedu/address/logic/commands/FindCommand.java 90.00% <ø> (ø) 5.00 <0.00> (ø)
...eedu/address/logic/commands/FindLessonCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ddress/logic/parser/DeleteLessonCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../address/logic/parser/FindLessonCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...eedu/address/logic/parser/LessonCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/seedu/address/logic/parser/PlanusParser.java 65.21% <0.00%> (-2.97%) 11.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 66.66% <ø> (ø) 1.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 63.75% <0.00%> (-1.64%) 24.00 <0.00> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 118fb49...5711487. Read the comment docs.

Copy link

@nuovonatura nuovonatura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nuovonatura nuovonatura merged commit fce1c84 into master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Story A user story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a user, I can find tasks by module.
3 participants