Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gangwei/improve ui #210

Merged
merged 9 commits into from
Oct 28, 2020
Merged

Gangwei/improve ui #210

merged 9 commits into from
Oct 28, 2020

Conversation

nuovonatura
Copy link

No description provided.

@nuovonatura nuovonatura added type.Bug A bug priority.High Must do severity.High A flaw that affects most users and causes major problems for users. i.e., makes the product almost u labels Oct 28, 2020
@nuovonatura nuovonatura added this to the v1.3 milestone Oct 28, 2020
@nuovonatura nuovonatura self-assigned this Oct 28, 2020
@codecov-io
Copy link

Codecov Report

Merging #210 into master will decrease coverage by 0.09%.
The diff coverage is 9.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #210      +/-   ##
============================================
- Coverage     41.59%   41.49%   -0.10%     
  Complexity      547      547              
============================================
  Files           112      112              
  Lines          2741     2747       +6     
  Branches        392      392              
============================================
  Hits           1140     1140              
- Misses         1493     1499       +6     
  Partials        108      108
Impacted Files Coverage Δ Complexity Δ
.../main/java/seedu/address/ui/DataAnalysisPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rc/main/java/seedu/address/logic/LogicManager.java 60.00% <100.00%> (ø) 3.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87974f9...d114fc8. Read the comment docs.

@dearvae
Copy link

dearvae commented Oct 28, 2020

LGTM

dearvae
dearvae approved these changes Oct 28, 2020
View reviewed changes
Copy link

@dearvae dearvae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BobbyZhouZijian BobbyZhouZijian merged commit c0676d2 into master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dearvae dearvae dearvae approved these changes

Assignees

@nuovonatura nuovonatura

Labels
priority.High Must do severity.High A flaw that affects most users and causes major problems for users. i.e., makes the product almost u type.Bug A bug
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nuovonatura @codecov-io @dearvae @BobbyZhouZijian