Beining/fix done command bugs #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcTzh
reviewed
Nov 5, 2020
| } | ||
| return new DoneCommand(indexes, durations); | ||
| } catch (ParseException pe) { | ||
| throw new ParseException( | ||
| String.format(MESSAGE_INVALID_COMMAND_FORMAT, pe.getMessage(), DoneCommand.MESSAGE_USAGE), pe); | ||
| } catch (NumberFormatException ne) { | ||
| throw new ParseException("should be a positive number and the maximum duration is 2147483647 minutes"); |
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
============================================
+ Coverage 43.06% 43.46% +0.39%
- Complexity 570 579 +9
============================================
Files 114 114
Lines 2835 2860 +25
Branches 421 435 +14
============================================
+ Hits 1221 1243 +22
Misses 1481 1481
- Partials 133 136 +3
Continue to review full report at Codecov.
|
MarcTzh
reviewed
Nov 5, 2020
| @@ -19,9 +19,10 @@ public void isValidTitle() { | |||
|
|
|||
There was a problem hiding this comment.
Why is this called isValidTitle??? Rename
| @@ -19,9 +19,10 @@ public void isValidTitle() { | |||
|
|
|||
| // invalid duration | |||
| assertFalse(Duration.isValidDuration(-10)); // negative number | |||
There was a problem hiding this comment.
Test a few more values in each equivalence partition and especially near boundary values. Please include values such as 0, -1, some valid values and values near MAX_INT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #236 fix #220