Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gangwei/new ui #271

Merged
merged 8 commits into from
Nov 7, 2020
Merged

Gangwei/new ui #271

merged 8 commits into from
Nov 7, 2020

Conversation

nuovonatura
Copy link

@nuovonatura nuovonatura commented Nov 7, 2020

fixes #181
fixes #203
fixes #204
fixes #224
fixes #226
fixes #238
fixes #241
fixes #242

@nuovonatura nuovonatura added this to the v1.4 milestone Nov 7, 2020
@nuovonatura nuovonatura self-assigned this Nov 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #271 (c522966) into master (4843600) will decrease coverage by 5.28%.
The diff coverage is 1.96%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #271      +/-   ##
============================================
- Coverage     55.65%   50.37%   -5.29%     
  Complexity      713      713              
============================================
  Files           115      122       +7     
  Lines          2907     3216     +309     
  Branches        447      479      +32     
============================================
+ Hits           1618     1620       +2     
- Misses         1093     1400     +307     
  Partials        196      196              
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../seedu/address/logic/commands/CalendarCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...eedu/address/logic/commands/ListLessonCommand.java 25.00% <0.00%> (ø) 1.00 <0.00> (ø)
.../java/seedu/address/logic/parser/PlanusParser.java 72.00% <0.00%> (-3.00%) 14.00 <0.00> (ø)
src/main/java/seedu/address/model/task/Task.java 88.88% <ø> (ø) 3.00 <0.00> (ø)
...va/seedu/address/model/task/deadline/Deadline.java 63.88% <0.00%> (-0.90%) 33.00 <0.00> (ø)
...ain/java/seedu/address/model/task/event/Event.java 50.74% <0.00%> (-0.77%) 23.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/seedu/address/ui/card/CalendarDayEventCard.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../main/java/seedu/address/ui/card/DeadlineCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4843600...c522966. Read the comment docs.

Copy link

@BobbyZhouZijian BobbyZhouZijian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BobbyZhouZijian BobbyZhouZijian merged commit 2f09c57 into master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment