Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gabriella/update ug #279

Merged
merged 7 commits into from
Nov 9, 2020
Merged

Gabriella/update ug #279

merged 7 commits into from
Nov 9, 2020

Conversation

GabriellaTeh
Copy link

No description provided.

@GabriellaTeh GabriellaTeh self-assigned this Nov 8, 2020
docs/UserGuide.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #279 (07c27f1) into master (4e2fb6c) will increase coverage by 4.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #279      +/-   ##
============================================
+ Coverage     50.17%   54.32%   +4.15%     
- Complexity      713      806      +93     
============================================
  Files           122      122              
  Lines          3229     3435     +206     
  Branches        480      540      +60     
============================================
+ Hits           1620     1866     +246     
+ Misses         1413     1340      -73     
- Partials        196      229      +33     
Impacted Files Coverage Δ Complexity Δ
.../address/model/task/deadline/DeadlineDateTime.java 68.42% <0.00%> (-0.81%) 15.00% <0.00%> (+6.00%) ⬇️
src/main/java/seedu/address/ui/HelpWindow.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...c/main/java/seedu/address/model/lesson/Lesson.java 60.90% <0.00%> (+0.90%) 25.00% <0.00%> (+1.00%)
...ava/seedu/address/storage/JsonAdaptedDeadline.java 70.00% <0.00%> (+0.98%) 14.00% <0.00%> (+1.00%)
...n/java/seedu/address/storage/JsonAdaptedEvent.java 46.57% <0.00%> (+1.29%) 5.00% <0.00%> (+1.00%)
...rc/main/java/seedu/address/model/ModelManager.java 82.08% <0.00%> (+4.06%) 47.00% <0.00%> (+16.00%)
...va/seedu/address/model/task/deadline/Deadline.java 70.37% <0.00%> (+6.48%) 36.00% <0.00%> (+3.00%)
src/main/java/seedu/address/model/Planus.java 75.89% <0.00%> (+7.63%) 46.00% <0.00%> (+25.00%)
...ain/java/seedu/address/model/task/event/Event.java 59.45% <0.00%> (+8.71%) 26.00% <0.00%> (+3.00%)
...in/java/seedu/address/model/calendar/Calendar.java 77.77% <0.00%> (+11.11%) 18.00% <0.00%> (+2.00%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e2fb6c...07c27f1. Read the comment docs.

Copy link

@nuovonatura nuovonatura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nuovonatura nuovonatura merged commit d8b36df into master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants