Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Implementation details of Edit feature #115

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Update Implementation details of Edit feature #115

merged 3 commits into from
Oct 22, 2020

Conversation

xz0127
Copy link
Collaborator

@xz0127 xz0127 commented Oct 21, 2020

Update the implementation details of Edit feature. It is PARTIALLY done.

Todo:

  1. Sequence diagrams and activity diagrams to be added.
  2. Design considerations to be added.

@xz0127 xz0127 added this to the v1.3 milestone Oct 21, 2020
@xz0127 xz0127 self-assigned this Oct 21, 2020
@JinHao-L JinHao-L linked an issue Oct 21, 2020 that may be closed by this pull request
Update Developer's Guide design components #108
Closed
Avalionnet
Avalionnet approved these changes Oct 21, 2020
View reviewed changes
Copy link
Collaborator

@Avalionnet Avalionnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just remember to add in the diagrams in the next update 👍🏻

@Avalionnet Avalionnet merged commit 89c29f7 into AY2021S1-CS2103T-T12-4:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avalionnet Avalionnet Avalionnet approved these changes

@JinHao-L JinHao-L Awaiting requested review from JinHao-L

@ZhangWanlin98 ZhangWanlin98 Awaiting requested review from ZhangWanlin98

@YangYue128-helen YangYue128-helen Awaiting requested review from YangYue128-helen

Assignees

@xz0127 xz0127

Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Update Developer's Guide design components
2 participants
@xz0127 @Avalionnet