-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo/Redo implementation #125
Undo/Redo implementation #125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the minor comments, the rest LGTM 👍
The comments can be addressed in a separate PR if necessary
src/main/java/seedu/address/model/VersionedAppointmentBook.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/model/VersionedAppointmentBook.java
Outdated
Show resolved
Hide resolved
Extract two exceptions out from versionedAppointentBook and versionedPatientBook to avoid repetition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the minor comments mentioned, the rest LGTM! 👍 Good work and perhaps some additional parts have to be added when change
and available
commands are added in.
src/main/java/seedu/address/model/VersionedAppointmentBook.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/model/VersionedAppointmentBookTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
============================================
+ Coverage 77.17% 77.96% +0.79%
- Complexity 800 848 +48
============================================
Files 111 117 +6
Lines 2331 2451 +120
Branches 276 286 +10
============================================
+ Hits 1799 1911 +112
- Misses 451 455 +4
- Partials 81 85 +4
Continue to review full report at Codecov.
|
No description provided.