Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo/Redo implementation #125

Merged

Conversation

YangYue128-helen
Copy link
Collaborator

No description provided.

@YangYue128-helen YangYue128-helen self-assigned this Oct 25, 2020
@YangYue128-helen YangYue128-helen added the type.Enhancement 👍 New feature or improvement to existing story label Oct 25, 2020
@YangYue128-helen YangYue128-helen added this to the v1.3b milestone Oct 25, 2020
@YangYue128-helen YangYue128-helen linked an issue Oct 25, 2020 that may be closed by this pull request
Copy link
Collaborator

@JinHao-L JinHao-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor comments, the rest LGTM 👍
The comments can be addressed in a separate PR if necessary

YangYue128-helen and others added 2 commits October 27, 2020 20:31
Extract two exceptions out from versionedAppointentBook and versionedPatientBook to avoid repetition.
Copy link
Collaborator

@xz0127 xz0127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor comments mentioned, the rest LGTM! 👍 Good work and perhaps some additional parts have to be added when change and available commands are added in.

@codecov-io
Copy link

Codecov Report

Merging #125 into master will increase coverage by 0.79%.
The diff coverage is 92.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #125      +/-   ##
============================================
+ Coverage     77.17%   77.96%   +0.79%     
- Complexity      800      848      +48     
============================================
  Files           111      117       +6     
  Lines          2331     2451     +120     
  Branches        276      286      +10     
============================================
+ Hits           1799     1911     +112     
- Misses          451      455       +4     
- Partials         81       85       +4     
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/parser/NuudleParser.java 64.00% <0.00%> (-5.57%) 12.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...java/seedu/address/logic/commands/RedoCommand.java 81.81% <81.81%> (ø) 3.00 <3.00> (?)
...java/seedu/address/logic/commands/UndoCommand.java 81.81% <81.81%> (ø) 3.00 <3.00> (?)
...rc/main/java/seedu/address/model/ModelManager.java 96.07% <94.73%> (+0.72%) 49.00 <19.00> (+10.00)
.../seedu/address/model/VersionedAppointmentBook.java 96.66% <96.66%> (ø) 15.00 <15.00> (?)
...java/seedu/address/model/VersionedPatientBook.java 96.66% <96.66%> (ø) 15.00 <15.00> (?)
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <100.00%> (ø) 8.00 <0.00> (ø)
...va/seedu/address/logic/commands/AssignCommand.java 88.46% <100.00%> (+0.46%) 11.00 <0.00> (ø)
...va/seedu/address/logic/commands/CancelCommand.java 100.00% <100.00%> (ø) 10.00 <0.00> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c52d68...b611020. Read the comment docs.

@YangYue128-helen YangYue128-helen merged commit d102e39 into AY2021S1-CS2103T-T12-4:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Enhancement 👍 New feature or improvement to existing story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement undo/redo feature
4 participants