Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command history #128

Merged
merged 5 commits into from
Oct 28, 2020
Merged

Command history #128

merged 5 commits into from
Oct 28, 2020

Conversation

JinHao-L
Copy link
Collaborator

@JinHao-L JinHao-L commented Oct 27, 2020 •
edited

Implement command history

  • Users can now use the ⬆️ and ⬇️ button to traverse through the command history
  • Update Logic UML diagram

closes #129

@JinHao-L JinHao-L self-assigned this Oct 27, 2020
@JinHao-L JinHao-L added the type.Enhancement 👍 New feature or improvement to existing story label Oct 27, 2020
@JinHao-L JinHao-L added this to the v1.3b milestone Oct 27, 2020
xz0127
xz0127 approved these changes Oct 28, 2020
View reviewed changes
Copy link
Collaborator

@xz0127 xz0127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor comments mentioned, the rest LGTM! 👍

src/main/java/seedu/address/ui/CommandBox.java Outdated
}

/**
* Get previous command input.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it should be Gets here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting it!

src/main/java/seedu/address/ui/CommandBox.java Outdated
}

/**
* Get next command input.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it should be Gets here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting it!

@JinHao-L JinHao-L merged commit 85bb712 into AY2021S1-CS2103T-T12-4:master Oct 28, 2020
@JinHao-L JinHao-L deleted the branch-history branch October 28, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xz0127 xz0127 xz0127 approved these changes

@Avalionnet Avalionnet Awaiting requested review from Avalionnet

@YangYue128-helen YangYue128-helen Awaiting requested review from YangYue128-helen

@ZhangWanlin98 ZhangWanlin98 Awaiting requested review from ZhangWanlin98

Assignees

@JinHao-L JinHao-L

Labels
type.Enhancement 👍 New feature or improvement to existing story
Projects
None yet
Milestone
v1.3b
Development

Successfully merging this pull request may close these issues.

Implement command history
2 participants
@JinHao-L @xz0127