-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update edit feature implementation details in DG #135
Conversation
Update from team repo
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
============================================
+ Coverage 72.18% 73.08% +0.90%
- Complexity 801 849 +48
============================================
Files 113 119 +6
Lines 2520 2642 +122
Branches 312 322 +10
============================================
+ Hits 1819 1931 +112
- Misses 615 621 +6
- Partials 86 90 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The text in the diagram looks a bit small, but its not really an issue. (We can clean the documentation in milestone 1.4
Add design considerations for edit feature in DG.
Add activity diagram and sequence diagram for Edit Command in DG.