Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update edit feature implementation details in DG #135

Merged
merged 12 commits into from
Oct 28, 2020

Conversation

xz0127
Copy link
Collaborator

@xz0127 xz0127 commented Oct 28, 2020

Add design considerations for edit feature in DG.
Add activity diagram and sequence diagram for Edit Command in DG.

@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #135 into master will increase coverage by 0.90%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #135      +/-   ##
============================================
+ Coverage     72.18%   73.08%   +0.90%     
- Complexity      801      849      +48     
============================================
  Files           113      119       +6     
  Lines          2520     2642     +122     
  Branches        312      322      +10     
============================================
+ Hits           1819     1931     +112     
- Misses          615      621       +6     
- Partials         86       90       +4     
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/parser/NuudleParser.java 61.53% <0.00%> (-5.13%) 12.00% <0.00%> (ø%)
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <0.00%> (ø) 8.00% <0.00%> (ø%)
...java/seedu/address/logic/commands/DoneCommand.java 100.00% <0.00%> (ø) 11.00% <0.00%> (ø%)
...ava/seedu/address/logic/commands/ClearCommand.java 100.00% <0.00%> (ø) 2.00% <0.00%> (ø%)
...va/seedu/address/logic/commands/CancelCommand.java 100.00% <0.00%> (ø) 10.00% <0.00%> (ø%)
...va/seedu/address/logic/commands/ChangeCommand.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...va/seedu/address/logic/commands/DeleteCommand.java 100.00% <0.00%> (ø) 7.00% <0.00%> (ø%)
...ess/model/exceptions/NoUndoableStateException.java 100.00% <0.00%> (ø) 1.00% <0.00%> (?%)
...ess/model/exceptions/NoRedoableStateException.java 100.00% <0.00%> (ø) 1.00% <0.00%> (?%)
...java/seedu/address/logic/commands/UndoCommand.java 81.81% <0.00%> (ø) 3.00% <0.00%> (?%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71e7547...34771cc. Read the comment docs.

@xz0127 xz0127 marked this pull request as ready for review October 28, 2020 08:56
@Avalionnet Avalionnet added this to the v1.3b milestone Oct 28, 2020
@xz0127 xz0127 added the type.Documentation 📝 Updates to documentation label Oct 28, 2020
Copy link
Collaborator

@JinHao-L JinHao-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
The text in the diagram looks a bit small, but its not really an issue. (We can clean the documentation in milestone 1.4

@xz0127 xz0127 merged commit 7928cfa into AY2021S1-CS2103T-T12-4:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Documentation 📝 Updates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants