Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove email #81

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Remove email #81

merged 3 commits into from
Oct 7, 2020

Conversation

xz0127
Copy link
Collaborator

@xz0127 xz0127 commented Oct 7, 2020

Remove email field in person's model

@xz0127 xz0127 added this to the v1.2 milestone Oct 7, 2020
@xz0127 xz0127 self-assigned this Oct 7, 2020
@xz0127 xz0127 linked an issue Oct 7, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@05c66ee). Click here to learn what that means.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #81   +/-   ##
=========================================
  Coverage          ?   73.47%           
  Complexity        ?      477           
=========================================
  Files             ?       78           
  Lines             ?     1365           
  Branches          ?      150           
=========================================
  Hits              ?     1003           
  Misses            ?      321           
  Partials          ?       41           
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <ø> (ø) 8.00 <0.00> (?)
...ain/java/seedu/address/logic/parser/CliSyntax.java 80.00% <ø> (ø) 1.00 <0.00> (?)
...in/java/seedu/address/logic/parser/ParserUtil.java 96.77% <ø> (ø) 12.00 <0.00> (?)
.../java/seedu/address/model/util/SampleDataUtil.java 20.00% <ø> (ø) 1.00 <0.00> (?)
src/main/java/seedu/address/ui/PersonCard.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...c/main/java/seedu/address/model/person/Person.java 97.22% <75.00%> (ø) 18.00 <0.00> (?)
...java/seedu/address/logic/commands/EditCommand.java 96.72% <100.00%> (ø) 12.00 <0.00> (?)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (?)
.../seedu/address/logic/parser/EditCommandParser.java 91.66% <100.00%> (ø) 10.00 <0.00> (?)
.../java/seedu/address/storage/JsonAdaptedPerson.java 100.00% <100.00%> (ø) 9.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05c66ee...95027a8. Read the comment docs.

Copy link
Collaborator

@JinHao-L JinHao-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@YangYue128-helen YangYue128-helen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@Avalionnet Avalionnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job with the refactoring 👍🏻

@xz0127 xz0127 merged commit 989c143 into AY2021S1-CS2103T-T12-4:master Oct 7, 2020
@xz0127 xz0127 mentioned this pull request Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove email field in patient's model
5 participants