Add ViewCommand and ViewCommandParser #91
Conversation
Add AssignCommand and AssignCommandParser
update appointment card and ui
ZhangWanlin98
requested review from
Avalionnet,
JinHao-L,
xz0127 and
YangYue128-helen
…into AY2021S1-CS2103T-T12-4-master # Conflicts: # src/test/java/seedu/address/logic/commands/AssignCommandTest.java # src/test/java/seedu/address/testutil/TypicalAppointments.java
| if (argMultimap.getValue(PREFIX_DATE).isEmpty()) { | ||
| throw new ParseException( | ||
| String.format(MESSAGE_INVALID_COMMAND_FORMAT, ViewCommand.MESSAGE_USAGE) | ||
| ); |
There was a problem hiding this comment.
Shall we consider the situation when a nurse wants to view the whole appointment list (without a date specified)?
There was a problem hiding this comment.
I think that he handled this under NuudleParser but I think it would be better to do the argument checking in this file instead?
Maybe can try doing the isEmpty check before tokenize?
There was a problem hiding this comment.
Hmm, as @YangYue128-helen mentioned, perhaps it'll be ok to leave out this check as we are able to support view commands without a DATE predicate as well?
Based on line 53 of ViewCommand.java, the current system seems to support the display of all future appointments if the predicate input is null (in the case that a date is not entered by the user) so I think you've got it covered @ZhangWanlin98 👍🏻
There was a problem hiding this comment.
Oh wait after reviewing NuudleParser as mentioned by @JinHao-L , I think the check done here is actually valid as the ViewCommandParser is only instantiated if extra input by the user following the view command is detected. Hence, it actually indicates an invalid command format if PREFIX_DATE is empty as it would mean that something else is written.
There was a problem hiding this comment.
Hence, it actually indicates an invalid command format if PREFIX_DATE is empty as it would mean that something else is written
@Avalionnet yup, I covered empty arg in the switch cases in NuudleParser, which is just list other one word command
but now I have changed to cover it in the ViewCommandParser
I think both ways are good, what yall think?
| if (argMultimap.getValue(PREFIX_DATE).isEmpty()) { | ||
| throw new ParseException( | ||
| String.format(MESSAGE_INVALID_COMMAND_FORMAT, ViewCommand.MESSAGE_USAGE) | ||
| ); |
There was a problem hiding this comment.
I think that he handled this under NuudleParser but I think it would be better to do the argument checking in this file instead?
Maybe can try doing the isEmpty check before tokenize?
| if (argMultimap.getValue(PREFIX_DATE).isEmpty()) { | ||
| throw new ParseException( | ||
| String.format(MESSAGE_INVALID_COMMAND_FORMAT, ViewCommand.MESSAGE_USAGE) | ||
| ); |
There was a problem hiding this comment.
Hmm, as @YangYue128-helen mentioned, perhaps it'll be ok to leave out this check as we are able to support view commands without a DATE predicate as well?
Based on line 53 of ViewCommand.java, the current system seems to support the display of all future appointments if the predicate input is null (in the case that a date is not entered by the user) so I think you've got it covered @ZhangWanlin98 👍🏻
| if (argMultimap.getValue(PREFIX_DATE).isEmpty()) { | ||
| throw new ParseException( | ||
| String.format(MESSAGE_INVALID_COMMAND_FORMAT, ViewCommand.MESSAGE_USAGE) | ||
| ); |
There was a problem hiding this comment.
Oh wait after reviewing NuudleParser as mentioned by @JinHao-L , I think the check done here is actually valid as the ViewCommandParser is only instantiated if extra input by the user following the view command is detected. Hence, it actually indicates an invalid command format if PREFIX_DATE is empty as it would mean that something else is written.
Added ViewCommand, ViewCommandParser and DateMatchesPredicate classes and related tests.