-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unique identifier to Person class #127
Add unique identifier to Person class #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments are made. After finishing them, this can be approved.
…into branch-PersonIdentifier
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
============================================
+ Coverage 72.95% 73.43% +0.48%
- Complexity 690 716 +26
============================================
Files 106 107 +1
Lines 2074 2142 +68
Branches 233 247 +14
============================================
+ Hits 1513 1573 +60
- Misses 503 508 +5
- Partials 58 61 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add unique identifier to Person class. The field
id
is included to be used for identifying a unique person.