Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique identifier to Person class #127

Merged

Conversation

hhdqirui
Copy link

@hhdqirui hhdqirui commented Oct 7, 2020

Add unique identifier to Person class. The field id is included to be used for identifying a unique person.

@hhdqirui hhdqirui added this to the v1.2 milestone Oct 7, 2020
@hhdqirui hhdqirui self-assigned this Oct 7, 2020
@hhdqirui hhdqirui linked an issue Oct 7, 2020 that may be closed by this pull request
Copy link

@hopinxian hopinxian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments are made. After finishing them, this can be approved.

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #127 into master will increase coverage by 0.48%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #127      +/-   ##
============================================
+ Coverage     72.95%   73.43%   +0.48%     
- Complexity      690      716      +26     
============================================
  Files           106      107       +1     
  Lines          2074     2142      +68     
  Branches        233      247      +14     
============================================
+ Hits           1513     1573      +60     
- Misses          503      508       +5     
- Partials         58       61       +3     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/model/AddressBook.java 85.71% <50.00%> (-5.96%) 13.00 <1.00> (+1.00) ⬇️
...rc/main/java/seedu/address/model/ModelManager.java 88.88% <50.00%> (-1.64%) 41.00 <1.00> (+1.00) ⬇️
...java/seedu/address/logic/commands/EditCommand.java 95.34% <83.33%> (-0.95%) 12.00 <0.00> (ø)
...c/main/java/seedu/address/model/person/Person.java 95.00% <87.50%> (-3.04%) 37.00 <10.00> (+12.00) ⬇️
...a/seedu/address/model/person/UniquePersonList.java 94.64% <100.00%> (+1.95%) 30.00 <6.00> (+10.00)
...son/exceptions/PersonNotIdentifiableException.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
.../java/seedu/address/storage/JsonAdaptedPerson.java 100.00% <100.00%> (ø) 16.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d462e45...195754c. Read the comment docs.

Copy link
Collaborator

@KohHanMing KohHanMing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

@hopinxian hopinxian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siangernlow siangernlow merged commit ed7bcd7 into AY2021S1-CS2103T-T13-1:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unique identifier to Person class
5 participants