-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented generate locations by an infected person #132
Implemented generate locations by an infected person #132
Conversation
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
============================================
- Coverage 74.94% 74.83% -0.11%
- Complexity 743 765 +22
============================================
Files 109 111 +2
Lines 2219 2281 +62
Branches 259 269 +10
============================================
+ Hits 1663 1707 +44
- Misses 493 508 +15
- Partials 63 66 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly done. Just need some more tests and abstractions.
src/main/java/seedu/address/logic/commands/GenerateLocationsCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/commands/GenerateLocationsCommand.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/logic/commands/GenerateLocationsCommandTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please take note of the comments in the ModelPredicate class.
Pull request was merged using Admin powers without going through 2 approvals. |
Implemented generate locations by infected person