Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented generate locations by an infected person #132

Merged

Conversation

KohHanMing
Copy link
Collaborator

Implemented generate locations by infected person

@KohHanMing KohHanMing added this to the v1.2 milestone Oct 10, 2020
@KohHanMing KohHanMing self-assigned this Oct 10, 2020
@codecov-io
Copy link

codecov-io commented Oct 10, 2020

Codecov Report

Merging #132 into master will decrease coverage by 0.10%.
The diff coverage is 58.20%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #132      +/-   ##
============================================
- Coverage     74.94%   74.83%   -0.11%     
- Complexity      743      765      +22     
============================================
  Files           109      111       +2     
  Lines          2219     2281      +62     
  Branches        259      269      +10     
============================================
+ Hits           1663     1707      +44     
- Misses          493      508      +15     
- Partials         63       66       +3     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/MainApp.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 91.30% <0.00%> (-8.70%) 17.00 <0.00> (ø)
.../java/seedu/address/model/util/SampleDataUtil.java 6.00% <0.00%> (-3.68%) 1.00 <0.00> (ø)
.../main/java/seedu/address/model/ModelPredicate.java 76.92% <60.00%> (-10.58%) 8.00 <3.00> (+3.00) ⬇️
...s/logic/parser/GenerateLocationsCommandParser.java 88.88% <88.88%> (ø) 3.00 <3.00> (?)
...rc/main/java/seedu/address/logic/LogicManager.java 73.07% <100.00%> (+1.07%) 5.00 <0.00> (ø)
...dress/logic/commands/GenerateLocationsCommand.java 100.00% <100.00%> (ø) 13.00 <13.00> (?)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e52e5d...9a2d4fd. Read the comment docs.

@KohHanMing KohHanMing changed the title Generate locations Implemented generate locations by an infected person Oct 10, 2020
@KohHanMing KohHanMing added Implementation Coding required priority.Medium Medium priority, do after high priority labels Oct 10, 2020
Copy link

@hopinxian hopinxian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly done. Just need some more tests and abstractions.

Copy link

@siangernlow siangernlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please take note of the comments in the ModelPredicate class.

src/main/java/seedu/address/model/ModelPredicate.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/ModelPredicate.java Outdated Show resolved Hide resolved
@KohHanMing KohHanMing merged commit 9cfeae2 into AY2021S1-CS2103T-T13-1:master Oct 10, 2020
@hopinxian
Copy link

Pull request was merged using Admin powers without going through 2 approvals.
However, noted that I would have given approval after the recent commits, so no harm done. Please be careful in the future though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Implementation Coding required priority.Medium Medium priority, do after high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement list functionality to list locations that an infected person has been to
4 participants