Morphing ID to public identity #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopinxian
added
priority.High
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
=========================================
Coverage 74.70% 74.70%
Complexity 801 801
=========================================
Files 113 113
Lines 2479 2479
Branches 308 308
=========================================
Hits 1852 1852
Misses 538 538
Partials 89 89 Continue to review full report at Codecov.
|
AddLocationCommandParser can parse and detect a string id which it passes to the location for storage as a string id. Tests have not been updated.
AddPersonCommandParser can parse and detect a string id which it passes to the person for storage as a string id. Tests have not been updated.
Add location and add person parsers can parse ids. Location and Person objects now store an id instead of string for the unique identifier.
Fix bug in generate commands due to misuse of id as index when checking if person is infected.
VirusTracker can now be built, but there are failing tests.
More tests still failing but half cleared.
IDs used in tests are two characters with the first being a letter and the second being a digit. Location IDs use L for the letter (e.g. L1) while person IDs use S for the letter (e.g. S1).
Delete person command is now overloaded to take in either index or id to identify person to be deleted.
Delete location command is now overloaded to take in either index or id to identify person to be deleted.
…into v1.3/publicID # Conflicts: # src/main/java/seedu/address/commons/core/Messages.java # src/test/data/JsonSerializableVisitBookTest/typicalVisitVisitBook.json # src/test/java/seedu/address/testutil/TypicalVisits.java
Add visit command can now take in either Id or index as input.
…into v1.3/publicID
|
This pull request is ready for merging. |
|
While all effort has been made not to regress VirusTracker in this PR, because ID is used widely across all aspects of the VirusTracker, it is recommended that all teammates check through the tests and functionality in detail for any breaking of code or bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to resolve #167
Users are now required to input a unique identifier for all locations and persons inputted into the system.
The following features come attached with the morphing of ID to a public unique identifier:
This is currently a draft pull request.