Fix bugs with misuse of sample visits and update UG #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: It is possible for MainApp to initialise using sample visits without sample locations and persons. This is a bug since visitbook would be having visits where the persons and locations involved are not in personbook and locationbook. Solution: If any of the location, person and visit data is empty, use all of sample visits, persons and locations.
hopinxian
added
bug
…into v1.3/Refactor # Conflicts: # src/main/java/seedu/address/ui/HelpWindow.java
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
============================================
+ Coverage 77.75% 78.04% +0.28%
Complexity 996 996
============================================
Files 125 125
Lines 2985 2974 -11
Branches 399 397 -2
============================================
Hits 2321 2321
+ Misses 535 524 -11
Partials 129 129
Continue to review full report at Codecov.
|
hopinxian
changed the title
…into v1.3/Refactor # Conflicts: # docs/UserGuide.md
|
Summary command table in UG is deleted. It can be added back with the correct commands in next iteration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft Pull Request