Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix for Mock PE #260

Merged
merged 6 commits into from
Oct 31, 2020
Merged

Bug Fix for Mock PE #260

merged 6 commits into from
Oct 31, 2020

Conversation

siangernlow
Copy link

@siangernlow
Resolve AY2021S1-CS2103T-T13-1#235
fbba702
@siangernlow
[User Guide] Resolve AY2021S1-CS2103T-T13-1#258
3c25fcb 
`Archiving data files` section should be removed
@siangernlow
[User Guide] Resove AY2021S1-CS2103T-T13-1#257
a79cc9b 
Give the correct link to the jar file inside `Quick Start`
@siangernlow
[AddVisitCommand] Resolve AY2021S1-CS2103T-T13-1#251
80f9369 
Add spaces for `idp/PERSON_IDidl/LOCATION_ID)d/DATE
@siangernlow
[AddPersonCommand] Resolve AY2021S1-CS2103T-T13-1#250
04c48af 
Remove space in `q/ QUARANTINE_STATUS`
@siangernlow
[User Guide] Resolve AY2021S1-CS2103T-T13-1#239
e5b2f95 
Move the list section so that it appears before the delete section
which references list
@siangernlow siangernlow added bug Something isn't working priority.High Needs to be completed soon labels Oct 31, 2020
@siangernlow siangernlow added this to the v1.4 milestone Oct 31, 2020
@siangernlow siangernlow self-assigned this Oct 31, 2020
@codecov-io
Copy link

Codecov Report

Merging #260 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #260   +/-   ##
=========================================
  Coverage     84.06%   84.06%           
  Complexity     1108     1108           
=========================================
  Files           125      125           
  Lines          3000     3000           
  Branches        399      399           
=========================================
  Hits           2522     2522           
  Misses          397      397           
  Partials         81       81
Impacted Files Coverage Δ Complexity Δ
...ddress/logic/commands/person/AddPersonCommand.java 100.00% <ø> (ø) 9.00 <0.00> (ø)
.../address/logic/commands/visit/AddVisitCommand.java 91.17% <ø> (ø) 22.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8473062...e5b2f95. Read the comment docs.

hopinxian
hopinxian approved these changes Oct 31, 2020
View reviewed changes
Copy link

@hopinxian hopinxian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on the bugs so quickly.

@hopinxian hopinxian merged commit 3725f09 into AY2021S1-CS2103T-T13-1:master Oct 31, 2020
@hopinxian hopinxian mentioned this pull request Oct 31, 2020
Closed
This was linked to issues Oct 31, 2020
[PE-D] Glossary table formatting is off #235
Closed
[PE-D] Use of "list" command in "delete" #239
Closed
[PE-D] Inconsistent formatting of the addPerson command parameters given #250
Closed
[PE-D] Formatting issue with addVisit command #251
Closed
[PE-D] Wrong hyperlink in UG Quick Start #257
Closed
[PE-D] Incomplete feature description for Archiving #258
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hopinxian hopinxian hopinxian approved these changes

Assignees

@siangernlow siangernlow

Labels
bug Something isn't working priority.High Needs to be completed soon
Projects
None yet
Milestone
v1.4
3 participants
@siangernlow @codecov-io @hopinxian